Marked internal API experimental.

michaelstaib · michaelstaib · commit fe1f2167d835 · 2024-10-03T11:09:03.000+02:00
diff --git a/src/HotChocolate/ApolloFederation/src/ApolloFederation/FederationTypeInterceptor.cs b/src/HotChocolate/ApolloFederation/src/ApolloFederation/FederationTypeInterceptor.cs
@@ -314,7 +314,7 @@ private void RegisterExportedDirectives()
         }
     }
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Caching/src/Caching/CacheControlValidationTypeInterceptor.cs b/src/HotChocolate/Caching/src/Caching/CacheControlValidationTypeInterceptor.cs
@@ -10,7 +10,7 @@ internal sealed class CacheControlValidationTypeInterceptor : TypeInterceptor
 {
     private ITypeCompletionContext _queryContext = default!;
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Caching/src/Caching/HotChocolate.Caching.csproj b/src/HotChocolate/Caching/src/Caching/HotChocolate.Caching.csproj
@@ -13,6 +13,7 @@
     <PackageId>HotChocolate.Caching</PackageId>
     <AssemblyName>HotChocolate.Caching</AssemblyName>
     <RootNamespace>HotChocolate.Caching</RootNamespace>
+    <NoWarn>HC8001;$(NoWarn)</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Core/src/Authorization/AuthorizationTypeInterceptor.cs b/src/HotChocolate/Core/src/Authorization/AuthorizationTypeInterceptor.cs
@@ -99,7 +99,7 @@ public override void OnBeforeCompleteTypes()
         FindFieldsAndApplyAuthMiddleware(state);
     }
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Core/src/Authorization/HotChocolate.Authorization.csproj b/src/HotChocolate/Core/src/Authorization/HotChocolate.Authorization.csproj
@@ -5,6 +5,7 @@
     <AssemblyName>HotChocolate.Authorization</AssemblyName>
     <RootNamespace>HotChocolate.Authorization</RootNamespace>
     <Description>This package contains the authorization abstractions for Hot Chocolate.</Description>
+    <NoWarn>HC8001;$(NoWarn)</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Core/src/Fetching/DataLoaderRootFieldTypeInterceptor.cs b/src/HotChocolate/Core/src/Fetching/DataLoaderRootFieldTypeInterceptor.cs
@@ -29,7 +29,7 @@ internal override void InitializeContext(
     internal override bool IsEnabled(IDescriptorContext context)
         => context.Options.PublishRootFieldPagesToPromiseCache;
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Core/src/Fetching/HotChocolate.Fetching.csproj b/src/HotChocolate/Core/src/Fetching/HotChocolate.Fetching.csproj
@@ -4,6 +4,7 @@
     <PackageId>HotChocolate.Fetching</PackageId>
     <AssemblyName>HotChocolate.Fetching</AssemblyName>
     <RootNamespace>HotChocolate.Fetching</RootNamespace>
+    <NoWarn>HC8001;$(NoWarn)</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Core/src/Types.Queries/HotChocolate.Types.Queries.csproj b/src/HotChocolate/Core/src/Types.Queries/HotChocolate.Types.Queries.csproj
@@ -5,6 +5,7 @@
   <AssemblyName>HotChocolate.Types.Queries</AssemblyName>
     <RootNamespace>HotChocolate.Types</RootNamespace>
     <Description>This package provides helpers for creating GraphQL queries.</Description>
+    <NoWarn>HC8001;$(NoWarn)</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Core/src/Types.Queries/QueryConventionTypeInterceptor.cs b/src/HotChocolate/Core/src/Types.Queries/QueryConventionTypeInterceptor.cs
@@ -26,7 +26,7 @@ internal override void InitializeContext(
         _errorTypeHelper.InitializerErrorTypeInterface(_context);
     }
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Core/src/Types/Configuration/AggregateTypeInterceptor.cs b/src/HotChocolate/Core/src/Types/Configuration/AggregateTypeInterceptor.cs
@@ -270,7 +270,7 @@ public override void OnAfterCompleteName(
         }
     }
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Core/src/Types/Configuration/Contracts/ITypeCompletionContext.cs b/src/HotChocolate/Core/src/Types/Configuration/Contracts/ITypeCompletionContext.cs
@@ -73,6 +73,16 @@ public interface ITypeCompletionContext : ITypeSystemObjectContext
     /// </summary>
     IEnumerable<T> GetTypes<T>() where T : IType;
 
+    /// <summary>
+    /// Tries to resolve a directive type by its <paramref name="directiveRef" />.
+    /// </summary>
+    /// <param name="directiveRef">
+    /// The directive reference representing the directive.
+    /// </param>
+    /// <param name="directiveType">
+    /// The resolved directive type.
+    /// </param>
+    /// <returns></returns>
     bool TryGetDirectiveType(
         TypeReference directiveRef,
         [NotNullWhen(true)] out DirectiveType? directiveType);
diff --git a/src/HotChocolate/Core/src/Types/Configuration/OnAfterSchemaCreate.cs b/src/HotChocolate/Core/src/Types/Configuration/OnAfterSchemaCreate.cs
@@ -2,6 +2,9 @@
 
 namespace HotChocolate.Configuration;
 
+/// <summary>
+/// Represents a callback that is invoked after a schema has been created.
+/// </summary>
 public delegate void OnAfterSchemaCreate(
     IDescriptorContext descriptorContext,
     ISchema schema);
diff --git a/src/HotChocolate/Core/src/Types/Configuration/OnBeforeSchemaCreate.cs b/src/HotChocolate/Core/src/Types/Configuration/OnBeforeSchemaCreate.cs
@@ -2,6 +2,9 @@
 
 namespace HotChocolate.Configuration;
 
+/// <summary>
+/// Represents a callback that is invoked before a schema is created.
+/// </summary>
 public delegate void OnBeforeSchemaCreate(
     IDescriptorContext descriptorContext,
     ISchemaBuilder schemaBuilder);
diff --git a/src/HotChocolate/Core/src/Types/Configuration/OnCompleteType.cs b/src/HotChocolate/Core/src/Types/Configuration/OnCompleteType.cs
@@ -4,6 +4,9 @@
 
 namespace HotChocolate.Configuration;
 
+/// <summary>
+/// Represents a callback that is invoked when a type has been completed.
+/// </summary>
 public delegate void OnCompleteType(
     ITypeCompletionContext context,
     DefinitionBase? definition,
diff --git a/src/HotChocolate/Core/src/Types/Configuration/OnCompleteType~1.cs b/src/HotChocolate/Core/src/Types/Configuration/OnCompleteType~1.cs
@@ -4,6 +4,10 @@
 
 namespace HotChocolate.Configuration;
 
+/// <summary>
+/// Represents a callback that is invoked when a type has been completed.
+/// </summary>
+/// <typeparam name="T"></typeparam>
 public delegate void OnCompleteType<T>(
     ITypeCompletionContext context,
     T? definition,
diff --git a/src/HotChocolate/Core/src/Types/Configuration/OnInitializeType.cs b/src/HotChocolate/Core/src/Types/Configuration/OnInitializeType.cs
@@ -4,6 +4,9 @@
 
 namespace HotChocolate.Configuration;
 
+/// <summary>
+/// Represents a callback that is invoked when a type has been completed.
+/// </summary>
 public delegate void OnInitializeType(
     ITypeDiscoveryContext context,
     DefinitionBase? definition,
diff --git a/src/HotChocolate/Core/src/Types/Configuration/OnInitializeType~1.cs b/src/HotChocolate/Core/src/Types/Configuration/OnInitializeType~1.cs
@@ -4,6 +4,10 @@
 
 namespace HotChocolate.Configuration;
 
+/// <summary>
+/// Represents a callback that is invoked when a type has been completed.
+/// </summary>
+/// <typeparam name="T"></typeparam>
 public delegate void OnInitializeType<T>(
     ITypeDiscoveryContext context,
     T? definition,
diff --git a/src/HotChocolate/Core/src/Types/Configuration/OnSchemaError.cs b/src/HotChocolate/Core/src/Types/Configuration/OnSchemaError.cs
@@ -2,6 +2,9 @@
 
 namespace HotChocolate.Configuration;
 
+/// <summary>
+/// Represents a callback that is invoked when an error occurs during schema creation.
+/// </summary>
 public delegate void OnSchemaError(
     IDescriptorContext descriptorContext,
     Exception exception);
diff --git a/src/HotChocolate/Core/src/Types/Configuration/TypeInterceptor.cs b/src/HotChocolate/Core/src/Types/Configuration/TypeInterceptor.cs
@@ -124,6 +124,9 @@ public virtual void OnTypeRegistered(
     {
     }
 
+    /// <summary>
+    /// This event is called after all types are initialized.
+    /// </summary>
     public virtual void OnTypesInitialized() { }
 
     /// <summary>
@@ -198,7 +201,22 @@ public virtual void OnAfterCompleteName(
     {
     }
 
-    internal virtual void OnAfterResolveRootType(
+    /// <summary>
+    /// This event is called after the root type is resolved.
+    /// </summary>
+    /// <param name="completionContext">
+    /// The type completion context.
+    /// </param>
+    /// <param name="definition">
+    /// The type definition of the type system member.
+    /// </param>
+    /// <param name="operationType">
+    /// Specifies what kind of operation type is resolved.
+    /// </param>
+    #if NET8_0_OR_GREATER
+    [Experimental(Experiments.RootTypeResolved)]
+    #endif
+    public virtual void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Core/src/Types/Experiments.cs b/src/HotChocolate/Core/src/Types/Experiments.cs
@@ -0,0 +1,6 @@
+namespace HotChocolate;
+
+internal static class Experiments
+{
+    public const string RootTypeResolved = "HC8001";
+}
diff --git a/src/HotChocolate/Core/src/Types/HotChocolate.Types.csproj b/src/HotChocolate/Core/src/Types/HotChocolate.Types.csproj
@@ -3,6 +3,7 @@
   <PropertyGroup>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <Nullable>disable</Nullable>
+    <NoWarn>HC8001;$(NoWarn)</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/HotChocolate/Core/src/Types/Types/Introspection/IntrospectionTypeInterceptor.cs b/src/HotChocolate/Core/src/Types/Types/Introspection/IntrospectionTypeInterceptor.cs
@@ -36,7 +36,7 @@ public override void OnAfterCompleteName(
         }
     }
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Core/src/Types/Types/Relay/NodeFieldTypeInterceptor.cs b/src/HotChocolate/Core/src/Types/Types/Relay/NodeFieldTypeInterceptor.cs
@@ -22,7 +22,7 @@ internal sealed class NodeFieldTypeInterceptor : TypeInterceptor
 
     internal override uint Position => uint.MaxValue - 100;
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Core/src/Types/Types/Relay/NodeResolverTypeInterceptor.cs b/src/HotChocolate/Core/src/Types/Types/Relay/NodeResolverTypeInterceptor.cs
@@ -34,7 +34,7 @@ private bool IsInitialized
             TypeDef is not null &&
             CompletionContext is not null;
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Core/src/Types/Types/Relay/QueryFieldTypeInterceptor.cs b/src/HotChocolate/Core/src/Types/Types/Relay/QueryFieldTypeInterceptor.cs
@@ -19,7 +19,7 @@ internal sealed class QueryFieldTypeInterceptor : TypeInterceptor
     private ObjectFieldDefinition _queryField = default!;
     private ObjectTypeDefinition? _mutationDefinition;
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)
diff --git a/src/HotChocolate/Core/test/Execution.Tests/Projections/ProjectableDataLoaderTests.cs b/src/HotChocolate/Core/test/Execution.Tests/Projections/ProjectableDataLoaderTests.cs
@@ -5,6 +5,10 @@
 using HotChocolate.Execution.Processing;
 using HotChocolate.Execution.TestContext;
 using HotChocolate.Types;
+<<<<<<< Updated upstream
+=======
+using HotChocolate.Types.Relay;
+>>>>>>> Stashed changes
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
 using Squadron;
diff --git a/src/HotChocolate/Data/src/Data/HotChocolate.Data.csproj b/src/HotChocolate/Data/src/Data/HotChocolate.Data.csproj
@@ -5,6 +5,7 @@
     <AssemblyName>HotChocolate.Data</AssemblyName>
     <RootNamespace>HotChocolate.Data</RootNamespace>
     <Description>Contains ready to use extensions for data management in HotChocolate. This includes filtering, projections and sorting</Description>
+    <NoWarn>HC8001;$(NoWarn)</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Data/src/Data/Projections/ProjectionTypeInterceptor.cs b/src/HotChocolate/Data/src/Data/Projections/ProjectionTypeInterceptor.cs
@@ -11,7 +11,7 @@ internal sealed class ProjectionTypeInterceptor : TypeInterceptor
 {
     private ITypeCompletionContext? _queryContext;
 
-    internal override void OnAfterResolveRootType(
+    public override void OnAfterResolveRootType(
         ITypeCompletionContext completionContext,
         ObjectTypeDefinition definition,
         OperationType operationType)

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ private void RegisterExportedDirectives()`
`314`	`314`	`}`
`315`	`315`	`}`
`316`	`316`
`317`		`- internal override void OnAfterResolveRootType(`
	`317`	`+ public override void OnAfterResolveRootType(`
`318`	`318`	`ITypeCompletionContext completionContext,`
`319`	`319`	`ObjectTypeDefinition definition,`
`320`	`320`	`OperationType operationType)`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ internal sealed class CacheControlValidationTypeInterceptor : TypeInterceptor`
`10`	`10`	`{`
`11`	`11`	`private ITypeCompletionContext _queryContext = default!;`
`12`	`12`
`13`		`- internal override void OnAfterResolveRootType(`
	`13`	`+ public override void OnAfterResolveRootType(`
`14`	`14`	`ITypeCompletionContext completionContext,`
`15`	`15`	`ObjectTypeDefinition definition,`
`16`	`16`	`OperationType operationType)`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ public override void OnBeforeCompleteTypes()`
`99`	`99`	`FindFieldsAndApplyAuthMiddleware(state);`
`100`	`100`	`}`
`101`	`101`
`102`		`- internal override void OnAfterResolveRootType(`
	`102`	`+ public override void OnAfterResolveRootType(`
`103`	`103`	`ITypeCompletionContext completionContext,`
`104`	`104`	`ObjectTypeDefinition definition,`
`105`	`105`	`OperationType operationType)`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ internal override void InitializeContext(`
`26`	`26`	`_errorTypeHelper.InitializerErrorTypeInterface(_context);`
`27`	`27`	`}`
`28`	`28`
`29`		`- internal override void OnAfterResolveRootType(`
	`29`	`+ public override void OnAfterResolveRootType(`
`30`	`30`	`ITypeCompletionContext completionContext,`
`31`	`31`	`ObjectTypeDefinition definition,`
`32`	`32`	`OperationType operationType)`
Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ public override void OnAfterCompleteName(`
`270`	`270`	`}`
`271`	`271`	`}`
`272`	`272`
`273`		`- internal override void OnAfterResolveRootType(`
	`273`	`+ public override void OnAfterResolveRootType(`
`274`	`274`	`ITypeCompletionContext completionContext,`
`275`	`275`	`ObjectTypeDefinition definition,`
`276`	`276`	`OperationType operationType)`