Implementing query.ParameterizedThing.

dhermes · dhermes · commit 990f9a6a74dc · 2018-10-17T12:18:49.000-07:00
diff --git a/ndb/src/google/cloud/ndb/query.py b/ndb/src/google/cloud/ndb/query.py
@@ -51,9 +51,17 @@ def __init__(self, *args, **kwargs):
 
 
 class ParameterizedThing:
-    def __init__(self, *args, **kwargs):
+    """Base class for :class:`Parameter` and :class:`ParameterizedFunction`.
+
+    This exists purely for :func:`isinstance` checks.
+    """
+
+    def __eq__(self, other):
         raise NotImplementedError
 
+    def __ne__(self, other):
+        return not self == other
+
 
 class Parameter(ParameterizedThing):
     def __init__(self, *args, **kwargs):
diff --git a/ndb/tests/unit/test_query.py b/ndb/tests/unit/test_query.py
@@ -26,6 +26,20 @@ def test_Cursor():
     assert query.Cursor is NotImplemented
 
 
+class TestParameterizedThing:
+    @staticmethod
+    def test___eq__():
+        thing = query.ParameterizedThing()
+        with pytest.raises(NotImplementedError):
+            thing == None
+
+    @staticmethod
+    def test___ne__():
+        thing = query.ParameterizedThing()
+        with pytest.raises(NotImplementedError):
+            thing != None
+
+
 class TestConjunctionNode:
     @staticmethod
     def test_constructor():
@@ -88,13 +102,6 @@ def test_constructor():
             query.ParameterizedFunction()
 
 
-class TestParameterizedThing:
-    @staticmethod
-    def test_constructor():
-        with pytest.raises(NotImplementedError):
-            query.ParameterizedThing()
-
-
 class TestParameterNode:
     @staticmethod
     def test_constructor():
