chore(storage): Add tests to cover empty string/file upload (googleapis#19312)

bajajneha27 · web-flow · commit 6524e41b5510 · 2022-11-24T12:19:40.000+05:30
diff --git a/.github/workflows/storage-retry-conformance-test-against-emulator.yaml b/.github/workflows/storage-retry-conformance-test-against-emulator.yaml
@@ -24,7 +24,7 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-ruby@v1
+      - uses: ruby/setup-ruby@v1
         with:
           ruby-version: '2.6'
       - run: ruby --version
diff --git a/google-cloud-storage/acceptance/storage/file_test.rb b/google-cloud-storage/acceptance/storage/file_test.rb
@@ -457,6 +457,25 @@
     uploaded.delete
   end
 
+  it "should upload and download an empty file" do
+    begin
+      data = ""
+      file = StringIO.new
+
+      uploaded = bucket.create_file file, "uploaded/empty-file.txt"
+      _(uploaded.name).must_equal "uploaded/empty-file.txt"
+
+      downloadio = StringIO.new
+      downloaded = uploaded.download downloadio
+      _(downloaded).must_be_kind_of StringIO
+
+      downloaded_data = downloaded.string
+      _(downloaded_data).must_equal data
+    ensure
+      uploaded.delete
+    end
+  end
+
   it "should download and verify when Content-Encoding gzip response header with skip_decompress" do
     bucket = bucket_public
     file = bucket.file bucket_public_file_gzip
diff --git a/google-cloud-storage/test/google/cloud/storage/bucket_test.rb b/google-cloud-storage/test/google/cloud/storage/bucket_test.rb
@@ -588,6 +588,38 @@
     end
   end
 
+  it "creates an empty file" do
+    new_file_name = random_file_path
+
+    Tempfile.create ["google-cloud", ".txt"] do |tmpfile|
+      mock = Minitest::Mock.new
+      mock.expect :insert_object, create_file_gapi(bucket_user_project.name, new_file_name),
+        [bucket.name, empty_file_gapi], **insert_object_args(name: new_file_name, upload_source: tmpfile, user_project: "test", options: {retries: 0})
+
+      bucket_user_project.service.mocked_service = mock
+
+      created = bucket_user_project.create_file tmpfile, new_file_name
+      _(created.user_project).must_equal true
+
+      mock.verify
+    end
+  end
+
+  it "creates an file with a StringIO" do
+    new_file_name = random_file_path
+    new_file_contents = StringIO.new
+
+    mock = Minitest::Mock.new
+    mock.expect :insert_object, create_file_gapi(bucket.name, new_file_name),
+      [bucket.name, empty_file_gapi], **insert_object_args(name: new_file_name, upload_source: new_file_contents, options: {retries: 0})
+
+    bucket.service.mocked_service = mock
+
+    bucket.create_file new_file_contents, new_file_name
+
+    mock.verify
+  end
+
   it "raises when given a file that does not exist" do
     bad_file_path = "/this/file/does/not/exist.ext"
 
diff --git a/google-cloud-storage/test/google/cloud/storage/lazy/bucket_test.rb b/google-cloud-storage/test/google/cloud/storage/lazy/bucket_test.rb
@@ -336,6 +336,23 @@
     end
   end
 
+  it "creates an empty file" do
+    new_file_name = random_file_path
+
+    Tempfile.create ["google-cloud", ".txt"] do |tmpfile|
+      mock = Minitest::Mock.new
+      mock.expect :insert_object, create_file_gapi(bucket_user_project.name, new_file_name),
+        [bucket.name, empty_file_gapi], **insert_object_args(name: new_file_name, upload_source: tmpfile, user_project: "test", options: {retries: 0})
+
+      bucket_user_project.service.mocked_service = mock
+
+      created = bucket_user_project.create_file tmpfile, new_file_name
+      _(created.user_project).must_equal true
+
+      mock.verify
+    end
+  end
+
   it "raises when given a file that does not exist" do
     bad_file_path = "/this/file/does/not/exist.ext"
 
