I forgot [nan] != [nan]

hexagonrecursion · hexagonrecursion · commit 8937329935f7 · 2021-04-01T16:07:01.000+03:00
diff --git a/fuzz/differential_fuzzer.py b/fuzz/differential_fuzzer.py
@@ -4,6 +4,16 @@
 from msgpack import _cmsgpack, fallback
 
 
+def replace_nan(data, sentinel):
+    if type(data) == float and math.isnan(data):
+        return sentinel
+    if type(data) == list:
+        return [replace_nan(x, sentinel) for x in data]
+    if type(data) == dict:
+        return {k: replace_nan(v, sentinel) for k, v in data.items()}
+    return data
+
+
 def TestOneInput(data):
     try:
         from_extension = _cmsgpack.unpackb(data)
@@ -13,10 +23,8 @@ def TestOneInput(data):
         from_fallback = fallback.unpackb(data)
     except:
         return
-    good = from_extension == from_fallback or (
-        math.isnan(from_extension) and math.isnan(from_fallback)
-    )
-    if not good:
+    sentinel = object()
+    if replace_nan(from_extension, sentinel) != replace_nan(from_fallback, sentinel):
         raise RuntimeError(
             f"Decoding disagreement: input: {data}, from extension: {from_extension}, from fallback: {from_fallback}"
         )
