Fix Chat.join

delivrance · delivrance · commit 5599182fd192 · 2019-07-11T14:42:18.000+02:00
The bound method will only be able to make users join public chats that
have set a username.
diff --git a/pyrogram/client/types/user_and_chats/chat.py b/pyrogram/client/types/user_and_chats/chat.py
@@ -386,7 +386,6 @@ def set_description(self, description: str) -> bool:
             description=description
         )
 
-
     def set_photo(self, photo: str) -> bool:
         """Bound method *set_photo* of :obj:`Chat`.
 
@@ -688,14 +687,17 @@ def join(self):
 
                 chat.join()
 
+        Note:
+            This only works for public groups and channels that have set a username.
+
         Returns:
             :obj:`Chat`: On success, a chat object is returned.
 
         Raises:
             RPCError: In case of a Telegram RPC error.
         """
 
-        return self._client.join_chat(self.id)
+        return self._client.join_chat(self.username)
 
     def leave(self):
         """Bound method *leave* of :obj:`Chat`.
@@ -716,4 +718,3 @@ def leave(self):
         """
 
         return self._client.leave_chat(self.id)
-    
