Skip to content

Commit c2630ae

Browse files
amotokiDean Troyer
authored andcommitted
Use cliff formattable columns in object storage commands
Partial-Bug: #1687955 Partially implement blueprint osc-formattable-columns Change-Id: I65737561c9b5ef29f5878316d2ff89f3d538158f
1 parent 1a21f02 commit c2630ae

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

openstackclient/object/v1/account.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313

1414
"""Account v1 action implementations"""
1515

16+
from osc_lib.cli import format_columns
1617
from osc_lib.cli import parseractions
1718
from osc_lib.command import command
18-
from osc_lib import utils
1919
import six
2020

2121
from openstackclient.i18n import _
@@ -48,7 +48,8 @@ class ShowAccount(command.ShowOne):
4848
def take_action(self, parsed_args):
4949
data = self.app.client_manager.object_store.account_show()
5050
if 'properties' in data:
51-
data['properties'] = utils.format_dict(data.pop('properties'))
51+
data['properties'] = format_columns.DictColumn(
52+
data.pop('properties'))
5253
return zip(*sorted(six.iteritems(data)))
5354

5455

openstackclient/object/v1/container.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import logging
1919

20+
from osc_lib.cli import format_columns
2021
from osc_lib.cli import parseractions
2122
from osc_lib.command import command
2223
from osc_lib import utils
@@ -230,7 +231,7 @@ def take_action(self, parsed_args):
230231
container=parsed_args.container,
231232
)
232233
if 'properties' in data:
233-
data['properties'] = utils.format_dict(data.pop('properties'))
234+
data['properties'] = format_columns.DictColumn(data['properties'])
234235

235236
return zip(*sorted(six.iteritems(data)))
236237

openstackclient/object/v1/object.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import logging
1919

20+
from osc_lib.cli import format_columns
2021
from osc_lib.cli import parseractions
2122
from osc_lib.command import command
2223
from osc_lib import exceptions
@@ -284,7 +285,7 @@ def take_action(self, parsed_args):
284285
object=parsed_args.object,
285286
)
286287
if 'properties' in data:
287-
data['properties'] = utils.format_dict(data.pop('properties'))
288+
data['properties'] = format_columns.DictColumn(data['properties'])
288289

289290
return zip(*sorted(six.iteritems(data)))
290291

0 commit comments

Comments
 (0)