From b6bb2840be101cd63643ce679a43d040d8111443 Mon Sep 17 00:00:00 2001 From: John Spaetzel Date: Wed, 18 Jul 2018 17:08:49 -0700 Subject: [PATCH] Add and use exception constructor that takes httpCode in asHttpCode --- .../java/com/hellosign/sdk/HelloSignException.java | 4 ++++ src/main/java/com/hellosign/sdk/http/HttpClient.java | 2 +- .../java/com/hellosign/sdk/HelloSignClientTest.java | 10 ++++++++-- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/hellosign/sdk/HelloSignException.java b/src/main/java/com/hellosign/sdk/HelloSignException.java index 81b5335d..0f604afc 100644 --- a/src/main/java/com/hellosign/sdk/HelloSignException.java +++ b/src/main/java/com/hellosign/sdk/HelloSignException.java @@ -50,6 +50,10 @@ public HelloSignException(String message, Throwable e) { super(message, e); } + public HelloSignException(String message, Integer httpCode) { + this(message, httpCode, null, null); + } + public HelloSignException(String message, Integer httpCode, String type) { this(message, httpCode, type, null); } diff --git a/src/main/java/com/hellosign/sdk/http/HttpClient.java b/src/main/java/com/hellosign/sdk/http/HttpClient.java index 6e2670c5..ad3d80f0 100644 --- a/src/main/java/com/hellosign/sdk/http/HttpClient.java +++ b/src/main/java/com/hellosign/sdk/http/HttpClient.java @@ -279,7 +279,7 @@ public int asHttpCode() throws HelloSignException { reset(); return code; } - throw new HelloSignException("HTTP Code " + code); + throw new HelloSignException("HTTP Code " + code, code); } /** diff --git a/src/test/java/com/hellosign/sdk/HelloSignClientTest.java b/src/test/java/com/hellosign/sdk/HelloSignClientTest.java index 7c42190b..b8a06f5e 100644 --- a/src/test/java/com/hellosign/sdk/HelloSignClientTest.java +++ b/src/test/java/com/hellosign/sdk/HelloSignClientTest.java @@ -597,10 +597,16 @@ public void testCancelSignatureRequest() throws Exception { assertTrue(client.cancelSignatureRequest("9cc3d5819959419abee4dbff2073d497e7c0a962")); } - @Test(expected = HelloSignException.class) + @Test public void testCancelSignatureRequestInvalid() throws Exception { mockResponseCode(410); - client.cancelSignatureRequest("foo"); + try { + client.cancelSignatureRequest("foo"); + fail("Expected HelloSignException"); + } catch (HelloSignException e) { + assertEquals("HTTP Code 410", e.getMessage()); + assertEquals(410, (int) e.getHttpCode()); + } } @Test