bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (pythonGH-31153)

ZackerySpytz · web-flow · commit 59e004af6374 · 2022-02-06T23:40:54.000-08:00
va_end() must be called before returning.
diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-02-06-23-08-30.bpo-40479.zED3Zu.rst b/Misc/NEWS.d/next/Core and Builtins/2022-02-06-23-08-30.bpo-40479.zED3Zu.rst
@@ -0,0 +1 @@
+Add a missing call to ``va_end()`` in ``Modules/_hashopenssl.c``.
diff --git a/Modules/_hashopenssl.c b/Modules/_hashopenssl.c
@@ -266,6 +266,7 @@ _setException(PyObject *exc, const char* altmsg, ...)
         } else {
             PyErr_FormatV(exc, altmsg, vargs);
         }
+        va_end(vargs);
         return NULL;
     }
     va_end(vargs);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Add a missing call to ``va_end()`` in ``Modules/_hashopenssl.c``.
Original file line number	Diff line number	Diff line change
`@@ -266,6 +266,7 @@ _setException(PyObject exc, const char altmsg, ...)`
`266`	`266`	`} else {`
`267`	`267`	`PyErr_FormatV(exc, altmsg, vargs);`
`268`	`268`	`}`
	`269`	`+ va_end(vargs);`
`269`	`270`	`return NULL;`
`270`	`271`	`}`
`271`	`272`	`va_end(vargs);`