fix test config

felixdivo · felixdivo · commit f754a79f0bcb · 2019-05-02T12:07:48.000+02:00
diff --git a/test/config.py b/test/config.py
@@ -12,22 +12,25 @@
 from os import environ as environment
 
 
+def env(name): # type: bool
+    return environment.get(name, '').lower() in ("yes", "true", "t", "1")
+
+
 # ############################## Continuos integration
 
 # see here for the environment variables that are set on the CI servers:
 #   - https://docs.travis-ci.com/user/environment-variables/
 #   - https://www.appveyor.com/docs/environment-variables/
 
-IS_TRAVIS = environment.get('TRAVIS', '').lower() == 'true'
-IS_APPVEYOR = environment.get('APPVEYOR', '').lower() == 'true'
+IS_TRAVIS = env('TRAVIS')
+IS_APPVEYOR = env('APPVEYOR')
 
-IS_CI = IS_TRAVIS or IS_APPVEYOR or \
-        environment.get('CI', '').lower() == 'true' or \
-        environment.get('CONTINUOUS_INTEGRATION', '').lower() == 'true'
+IS_CI = IS_TRAVIS or IS_APPVEYOR or env('CI') or env('CONTINUOUS_INTEGRATION')
 
 if IS_APPVEYOR and IS_TRAVIS:
     raise EnvironmentError("IS_APPVEYOR and IS_TRAVIS cannot be both True at the same time")
 
+
 # ############################## Platforms
 
 _sys = platform.system().lower()
@@ -42,11 +45,10 @@
         "can be True at the same time " +
         '(platform.system() == "{}")'.format(platform.system())
     )
-elif not IS_WINDOWS and not IS_LINUX and not IS_OSX:
-    raise EnvironmentError("one of IS_WINDOWS, IS_LINUX, IS_OSX has to be True")
+
 
 # ############################## What tests to run
 
 TEST_CAN_FD = True
 
-TEST_INTERFACE_SOCKETCAN = IS_CI and IS_LINUX
+TEST_INTERFACE_SOCKETCAN = IS_LINUX and env('TEST_SOCKETCAN')
