Remove TODOs for issues 200/201 (temporalio#69)

r00ta · web-flow · commit d4e6c3667a39 · 2023-05-09T16:21:08.000-05:00
* remove TODOs for issues 200/201

* lint fix
diff --git a/hello/hello_activity_choice.py b/hello/hello_activity_choice.py
@@ -58,33 +58,31 @@ async def run(self, list: ShoppingList) -> str:
         # Order each thing on the list
         ordered: List[str] = []
         for item in list.items:
-            # TODO(cretz): Use "is" instead of "==" after
-            # https://github.com/temporalio/sdk-python/issues/200 is fixed
-            if item.fruit == Fruit.APPLE:
+            if item.fruit is Fruit.APPLE:
                 ordered.append(
                     await workflow.execute_activity(
                         order_apples,
                         item.amount,
                         start_to_close_timeout=timedelta(seconds=5),
                     )
                 )
-            elif item.fruit == Fruit.BANANA:
+            elif item.fruit is Fruit.BANANA:
                 ordered.append(
                     await workflow.execute_activity(
                         order_bananas,
                         item.amount,
                         start_to_close_timeout=timedelta(seconds=5),
                     )
                 )
-            elif item.fruit == Fruit.CHERRY:
+            elif item.fruit is Fruit.CHERRY:
                 ordered.append(
                     await workflow.execute_activity(
                         order_cherries,
                         item.amount,
                         start_to_close_timeout=timedelta(seconds=5),
                     )
                 )
-            elif item.fruit == Fruit.ORANGE:
+            elif item.fruit is Fruit.ORANGE:
                 ordered.append(
                     await workflow.execute_activity(
                         order_oranges,
diff --git a/hello/hello_activity_multiprocess.py b/hello/hello_activity_multiprocess.py
@@ -2,17 +2,14 @@
 import multiprocessing
 import os
 import time
+from concurrent.futures import ProcessPoolExecutor
 from dataclasses import dataclass
 from datetime import timedelta
 
 from temporalio import activity, workflow
 from temporalio.client import Client
 from temporalio.worker import SharedStateManager, Worker
 
-# TODO(cretz): https://github.com/temporalio/sdk-python/issues/201
-with workflow.unsafe.sandbox_unrestricted():
-    from concurrent.futures import ProcessPoolExecutor
-
 
 @dataclass
 class ComposeGreetingInput:
diff --git a/hello/hello_activity_threaded.py b/hello/hello_activity_threaded.py
@@ -1,17 +1,14 @@
 import asyncio
 import threading
 import time
+from concurrent.futures import ThreadPoolExecutor
 from dataclasses import dataclass
 from datetime import timedelta
 
 from temporalio import activity, workflow
 from temporalio.client import Client
 from temporalio.worker import Worker
 
-# TODO(cretz): https://github.com/temporalio/sdk-python/issues/201
-with workflow.unsafe.sandbox_unrestricted():
-    from concurrent.futures import ThreadPoolExecutor
-
 
 @dataclass
 class ComposeGreetingInput:
