Adjust unit tests now we're no longer raising out of stock exception

hjwp · hjwp · commit a46cd5ea6b49 · 2019-11-20T21:12:35.000Z
diff --git a/tests/unit/test_product.py b/tests/unit/test_product.py
@@ -1,6 +1,5 @@
 from datetime import date, timedelta
-import pytest
-from allocation import events, exceptions
+from allocation import events
 from allocation.model import Product, OrderLine, Batch
 
 today = date.today()
@@ -42,23 +41,14 @@ def test_returns_allocated_batch_ref():
     assert allocation == in_stock_batch.reference
 
 
-def test_raises_out_of_stock_exception_if_cannot_allocate():
+def test_records_out_of_stock_event_if_cannot_allocate():
     batch = Batch('batch1', 'SMALL-FORK', 10, eta=today)
     product = Product(sku="SMALL-FORK", batches=[batch])
     product.allocate(OrderLine('order1', 'SMALL-FORK', 10))
 
-    with pytest.raises(exceptions.OutOfStock, match='SMALL-FORK'):
-        product.allocate(OrderLine('order2', 'SMALL-FORK', 1))
-
-
-def test_records_out_of_stock_event_if_cannot_allocate():
-    sku1_batch = Batch('batch1', 'sku1', 100, eta=today)
-    sku2_line = OrderLine('oref', 'sku2', 10)
-    product = Product(sku='sku1', batches=[sku1_batch])
-
-    with pytest.raises(exceptions.OutOfStock):
-        product.allocate(sku2_line)
-    assert product.events[-1] == events.OutOfStock(sku='sku2')
+    allocation = product.allocate(OrderLine('order2', 'SMALL-FORK', 1))
+    assert product.events[-1] == events.OutOfStock(sku="SMALL-FORK")
+    assert allocation is None
 
 
 def test_increments_version_number():
diff --git a/tests/unit/test_services.py b/tests/unit/test_services.py
@@ -70,8 +70,7 @@ def test_sends_email_on_out_of_stock_error():
     services.add_batch("b1", "POPULAR-CURTAINS", 9, None, uow)
 
     with mock.patch("allocation.email.send_mail") as mock_send_mail:
-        with pytest.raises(exceptions.OutOfStock):
-            services.allocate("o1", "POPULAR-CURTAINS", 10, uow)
+        services.allocate("o1", "POPULAR-CURTAINS", 10, uow)
         assert mock_send_mail.call_args == mock.call(
             "stock@made.com",
             f"Out of stock for POPULAR-CURTAINS",
