Start moving to handlers [services_to_handlers]

hjwp · hjwp · commit 3ee6ed83591a · 2019-11-20T21:12:36.000Z
diff --git a/src/allocation/email.py b/src/allocation/email.py
@@ -1,2 +1,2 @@
-def send_mail(*args):
+def send(*args):
     print('SENDING EMAIL:', *args)
diff --git a/src/allocation/handlers.py b/src/allocation/handlers.py
@@ -1,33 +1,45 @@
 from __future__ import annotations
-from typing import Optional
-from datetime import date
-
-from allocation import exceptions, model, unit_of_work
+import typing
+from allocation import events, email, exceptions, model
 from allocation.model import OrderLine
+if typing.TYPE_CHECKING:
+    from allocation import unit_of_work
+
 
 
 def add_batch(
-        ref: str, sku: str, qty: int, eta: Optional[date],
-        uow: unit_of_work.AbstractUnitOfWork
+        event: events.BatchCreated, uow: unit_of_work.AbstractUnitOfWork
 ):
     with uow:
-        product = uow.products.get(sku=sku)
+        product = uow.products.get(sku=event.sku)
         if product is None:
-            product = model.Product(sku, batches=[])
+            product = model.Product(event.sku, batches=[])
             uow.products.add(product)
-        product.batches.append(model.Batch(ref, sku, qty, eta))
+        product.batches.append(model.Batch(
+            event.ref, event.sku, event.qty, event.eta
+        ))
         uow.commit()
 
 
 def allocate(
-        orderid: str, sku: str, qty: int,
-        uow: unit_of_work.AbstractUnitOfWork
+        event: events.AllocationRequired, uow: unit_of_work.AbstractUnitOfWork
 ) -> str:
-    line = OrderLine(orderid, sku, qty)
+    line = OrderLine(event.orderid, event.sku, event.qty)
     with uow:
         product = uow.products.get(sku=line.sku)
         if product is None:
             raise exceptions.InvalidSku(f'Invalid sku {line.sku}')
         batchref = product.allocate(line)
         uow.commit()
         return batchref
+
+
+# pylint: disable=unused-argument
+
+def send_out_of_stock_notification(
+        event: events.OutOfStock, uow: unit_of_work.AbstractUnitOfWork,
+):
+    email.send(
+        'stock@made.com',
+        f'Out of stock for {event.sku}',
+    )
diff --git a/src/allocation/messagebus.py b/src/allocation/messagebus.py
@@ -1,20 +1,14 @@
 from typing import List, Dict, Callable, Type
-from allocation import email, events
+from allocation import events, handlers
 
 
 def handle(event: events.Event):
     for handler in HANDLERS[type(event)]:
         handler(event)
 
 
-def send_out_of_stock_notification(event: events.OutOfStock):
-    email.send_mail(
-        'stock@made.com',
-        f'Out of stock for {event.sku}',
-    )
-
-
 HANDLERS = {
-    events.OutOfStock: [send_out_of_stock_notification],
-
+    events.BatchCreated: [handlers.add_batch],
+    events.AllocationRequired: [handlers.allocate],
+    events.OutOfStock: [handlers.send_out_of_stock_notification],
 }  # type: Dict[Type[events.Event], List[Callable]]

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`		`-def send_mail(*args):`
	`1`	`+def send(*args):`
`2`	`2`	`print('SENDING EMAIL:', *args)`