Implement support for timing parameters in can.ini for pcan#2069
Draft
geeak wants to merge 2 commits into
Draft
Conversation
Add support for building BitTiming object from kwargs, which makes it possible to support timing parameters from can.ini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add support for building BitTiming object from kwargs, which makes it possible to support timing parameters from can.ini. Whether this should be considered a new feature, or a bugfix for something that would be expected to be supported already, I leave up to others to decide.
This makes standard definitions like the example below work as expected in can.ini. CAN-FD support has not been implemented.
Related Issues / Pull Requests
This fixes #2068 for standard CAN
Type of Change
Checklist
tox).Additional Notes