Skip to content

Commit ba5bea1

Browse files
adrianspdevadrianspdev
authored
Remove deprecated packages (#12015)
* Remove angular wrapper * Remove react wrapper * Remove vue wrapper * Fix lint * Remove persistentState plugin * Update test cases and styles * Remove undo redo * Update docs deprecation policy page and pull request template * Add changelog entry * Update docs * Update methods tests
1 parent fcaa038 commit ba5bea1

594 files changed

Lines changed: 389 additions & 150678 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.changelogs/12015.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"issuesOrigin": "private",
3+
"title": "Removed deprecated packages Angular, React, Vue wrapper, persistentState plugin and hot undo redo methods",
4+
"type": "removed",
5+
"issueOrPR": 12015,
6+
"breaking": true,
7+
"framework": "none"
8+
}

‎.codesandbox/ci.json‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,16 @@
11
{
22
"buildCommand": "all build -- --e examples visual-tests",
33
"packages": [
4-
"wrappers/angular-wrapper",
54
"handsontable",
5+
"wrappers/angular-wrapper",
66
"wrappers/react-wrapper",
7-
"wrappers/vue",
87
"wrappers/vue3"
98
],
109
"publishDirectory": {
1110
"handsontable": "handsontable/tmp",
1211
"@handsontable/angular-wrapper": "wrappers/angular-wrapper/dist/hot-table",
1312
"@handsontable/react-wrapper": "wrappers/react-wrapper",
14-
"@handsontable/vue": "wrappers/vue",
1513
"@handsontable/vue3": "wrappers/vue3"
16-
1714
},
1815
"sandboxes": [
1916
"github/handsontable/handsontable/tree/develop/examples/prs/js/",

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,8 @@
1818

1919
### Affected project(s):
2020
- [ ] `handsontable`
21-
- [ ] `@handsontable/angular`
2221
- [ ] `@handsontable/angular-wrapper`
23-
- [ ] `@handsontable/react`
2422
- [ ] `@handsontable/react-wrapper`
25-
- [ ] `@handsontable/vue`
2623
- [ ] `@handsontable/vue3`
2724

2825
### Checklist:

‎.github/workflows/docs-staging.yml‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,8 @@ jobs:
104104
105105
mkdir -p docs/.vuepress/public/@handsontable
106106
107-
# cp -r ./wrappers/angular docs/.vuepress/public/@handsontable
108107
# cp -r ./wrappers/angular-wrapper docs/.vuepress/public/@handsontable
109-
# cp -r ./wrappers/react docs/.vuepress/public/@handsontable
110108
# cp -r ./wrappers/react-wrapper docs/.vuepress/public/@handsontable
111-
# cp -r ./wrappers/vue docs/.vuepress/public/@handsontable
112109
# cp -r ./wrappers/vue3 docs/.vuepress/public/@handsontable
113110

114111
cp -r ./wrappers/angular-wrapper/dist/hot-table docs/.vuepress/public/@handsontable/
@@ -142,17 +139,11 @@ jobs:
142139
cp -r ../../handsontable docs/docs
143140
144141
mkdir -p docs/docs/@handsontable
145-
rm -rf ../../@handsontable/angular/node_modules
146142
#rm -rf ../../@handsontable/angular-wrapper/node_modules
147-
rm -rf ../../@handsontable/react/node_modules
148143
rm -rf ../../@handsontable/react-wrapper/node_modules
149-
rm -rf ../../@handsontable/vue/node_modules
150144
rm -rf ../../@handsontable/vue3/node_modules
151-
cp -r ../../wrappers/angular docs/docs/@handsontable/
152145
#cp -r ../../wrappers/angular-wrapper docs/docs/@handsontable/
153-
cp -r ../../wrappers/react docs/docs/@handsontable/
154146
cp -r ../../wrappers/react-wrapper docs/docs/@handsontable/
155-
cp -r ../../wrappers/vue docs/docs/@handsontable/
156147
cp -r ../../wrappers/vue3 docs/docs/@handsontable/
157148
158149
- name: Publish preview to Netlify

‎.github/workflows/test.yml‎

Lines changed: 0 additions & 133 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,8 @@ jobs:
4040
test-handsontable-walkontable: ${{ steps.path-filter.outputs.test-handsontable-walkontable }}
4141
test-handsontable-e2e: ${{ steps.path-filter.outputs.test-handsontable-e2e }}
4242
test-handsontable-e2e-min: ${{ steps.path-filter.outputs.test-handsontable-e2e-min }}
43-
test-angular: ${{ steps.path-filter.outputs.test-angular }}
4443
test-angular-wrapper: ${{ steps.path-filter.outputs.test-angular-wrapper }}
45-
test-react: ${{ steps.path-filter.outputs.test-react }}
4644
test-react-wrapper: ${{ steps.path-filter.outputs.test-react-wrapper }}
47-
test-vue: ${{ steps.path-filter.outputs.test-vue }}
4845
test-vue3: ${{ steps.path-filter.outputs.test-vue3 }}
4946
test-visual: ${{ steps.path-filter.outputs.test-visual }}
5047
steps:
@@ -99,21 +96,12 @@ jobs:
9996
test-handsontable-e2e-min:
10097
- *hot-shared
10198
- *hot-e2e-test-shared
102-
test-angular:
103-
- *hot-shared
104-
- 'wrappers/angular/**'
10599
test-angular-wrapper:
106100
- *hot-shared
107101
- 'wrappers/angular-wrapper/**'
108-
test-react:
109-
- *hot-shared
110-
- 'wrappers/react/**'
111102
test-react-wrapper:
112103
- *hot-shared
113104
- 'wrappers/react-wrapper/**'
114-
test-vue:
115-
- *hot-shared
116-
- 'wrappers/vue/**'
117105
test-vue3:
118106
- *hot-shared
119107
- 'wrappers/vue3/**'
@@ -541,45 +529,6 @@ jobs:
541529
cd handsontable
542530
npm run test:e2e.dump.esm-cjs && npm run test:e2e.dump --theme=main && npm run test:e2e.puppeteer
543531
544-
test-angular:
545-
name: "[TEST] Wrapper: Angular"
546-
runs-on: ubuntu-latest
547-
needs: [ check-scope, build-handsontable-es-cjs ]
548-
if: |
549-
needs.check-scope.outputs.run-all == 'true' ||
550-
needs.check-scope.outputs.test-angular == 'true'
551-
steps:
552-
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # https://github.com/actions/checkout/releases/tag/v4.1.1
553-
554-
- uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
555-
name: Install pnpm
556-
557-
- name: Use Node.js
558-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # https://github.com/actions/setup-node/releases/tag/v4.4.0
559-
with:
560-
node-version-file: '.nvmrc'
561-
cache: 'pnpm'
562-
- run: pnpm install && pnpm -r rebuild
563-
564-
- name: Download the Handsontable build artifact
565-
uses: actions/download-artifact@87c55149d96e628cc2ef7e6fc2aab372015aec85 # https://github.com/actions/download-artifact/releases/tag/v4.1.3
566-
with:
567-
name: handsontable-build-es-cjs
568-
path: ./
569-
- run: tar -zxf tmp.tar.gz ./handsontable/tmp && rm tmp.tar.gz
570-
- run: cd handsontable
571-
- run: npm run in angular build
572-
- run: tar --exclude='node_modules' -zcf angular.tar.gz ./wrappers/angular
573-
574-
- name: Upload the Angular build artifact
575-
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # https://github.com/actions/upload-artifact/releases/tag/v4.3.1
576-
with:
577-
name: angular-build
578-
path: angular.tar.gz
579-
580-
- name: Test
581-
run: npm run in angular test:ci
582-
583532
test-angular-wrapper:
584533
name: "[TEST] Wrapper: Angular (modern)"
585534
runs-on: ubuntu-latest
@@ -619,44 +568,6 @@ jobs:
619568
- name: Test
620569
run: npm run in angular-wrapper test:ci
621570

622-
test-react:
623-
name: "[TEST] Wrapper: React"
624-
runs-on: ubuntu-latest
625-
needs: [ check-scope, build-handsontable-es-cjs ]
626-
if: |
627-
needs.check-scope.outputs.run-all == 'true' ||
628-
needs.check-scope.outputs.test-react == 'true'
629-
steps:
630-
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # https://github.com/actions/checkout/releases/tag/v4.1.1
631-
632-
- uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
633-
name: Install pnpm
634-
635-
- name: Use Node.js
636-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # https://github.com/actions/setup-node/releases/tag/v4.4.0
637-
with:
638-
node-version-file: '.nvmrc'
639-
cache: 'pnpm'
640-
- run: pnpm install && pnpm -r rebuild
641-
642-
- name: Download the Handsontable build artifact
643-
uses: actions/download-artifact@87c55149d96e628cc2ef7e6fc2aab372015aec85 # https://github.com/actions/download-artifact/releases/tag/v4.1.3
644-
with:
645-
name: handsontable-build-es-cjs
646-
path: ./
647-
- run: tar -zxf tmp.tar.gz ./handsontable/tmp && rm tmp.tar.gz
648-
- run: cd handsontable
649-
- run: npm run in react build
650-
- run: tar --exclude='node_modules' -zcf react.tar.gz ./wrappers/react
651-
652-
- name: Upload the React build artifact
653-
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # https://github.com/actions/upload-artifact/releases/tag/v4.3.1
654-
with:
655-
name: react-build
656-
path: react.tar.gz
657-
- name: Test
658-
run: npm run in react test
659-
660571
test-react-wrapper:
661572
name: "[TEST] Wrapper: React (functional)"
662573
runs-on: ubuntu-latest
@@ -695,44 +606,6 @@ jobs:
695606
- name: Test
696607
run: npm run in react-wrapper test
697608

698-
test-vue:
699-
name: "[TEST] Wrapper: Vue"
700-
runs-on: ubuntu-latest
701-
needs: [ check-scope, build-handsontable-es-cjs ]
702-
if: |
703-
needs.check-scope.outputs.run-all == 'true' ||
704-
needs.check-scope.outputs.test-vue == 'true'
705-
steps:
706-
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # https://github.com/actions/checkout/releases/tag/v4.1.1
707-
708-
- uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
709-
name: Install pnpm
710-
711-
- name: Use Node.js
712-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # https://github.com/actions/setup-node/releases/tag/v4.4.0
713-
with:
714-
node-version-file: '.nvmrc'
715-
cache: 'pnpm'
716-
- run: pnpm install && pnpm -r rebuild
717-
718-
- name: Download the Handsontable build artifact
719-
uses: actions/download-artifact@87c55149d96e628cc2ef7e6fc2aab372015aec85 # https://github.com/actions/download-artifact/releases/tag/v4.1.3
720-
with:
721-
name: handsontable-build-es-cjs
722-
path: ./
723-
- run: tar -zxf tmp.tar.gz ./handsontable/tmp && rm tmp.tar.gz
724-
- run: cd handsontable
725-
- run: npm run in vue build
726-
- run: tar --exclude='node_modules' -zcf vue.tar.gz ./wrappers/vue
727-
728-
- name: Upload the Vue2 build artifact
729-
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # https://github.com/actions/upload-artifact/releases/tag/v4.3.1
730-
with:
731-
name: vue-build
732-
path: vue.tar.gz
733-
- name: Test
734-
run: npm run in vue test
735-
736609
test-vue3:
737610
name: "[TEST] Wrapper: Vue3"
738611
runs-on: ubuntu-latest
@@ -781,23 +654,17 @@ jobs:
781654
- test-handsontable-e2e-min-main
782655
- test-handsontable-e2e-min-horizon
783656
- test-handsontable-e2e-min-classic
784-
- test-angular
785657
- test-angular-wrapper
786-
- test-react
787658
- test-react-wrapper
788-
- test-vue
789659
- test-vue3
790660
if: |
791661
!failure() && !cancelled() && (
792662
needs.test-handsontable-e2e-main.result == 'success' ||
793663
needs.test-handsontable-e2e-classic.result == 'success' ||
794664
needs.test-handsontable-e2e-min-main.result == 'success' ||
795665
needs.test-handsontable-e2e-min-classic.result == 'success' ||
796-
needs.test-angular.result == 'success' ||
797666
needs.test-angular-wrapper.result == 'success' ||
798-
needs.test-react.result == 'success' ||
799667
needs.test-react-wrapper.result == 'success' ||
800-
needs.test-vue.result == 'success' ||
801668
needs.test-vue3.result == 'success' ||
802669
needs.check-scope.outputs.test-visual == 'true'
803670
)

‎CONTRIBUTING.md‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,13 @@ To speed up the process of merging your changes, follow these rules:
1414
- Framework wrapper projects are located in the `./wrappers/` directory.
1515
5. Don't edit files in the following directories:
1616
- `./handsontable/dist/`
17-
- `./wrappers/angular/dist/hot-table/`
18-
- `./wrappers/react/dist/` & `./wrappers/react/es/` & `./wrappers/react/commonjs/`
19-
- `./wrappers/vue/dist/` & `./wrappers/vue/es/` & `./wrappers/vue/commonjs/`
17+
- `./wrappers/angular-wrapper/dist/hot-table/`
18+
- `./wrappers/vue3/dist/` & `./wrappers/vue3/es/` & `./wrappers/vue3/commonjs/`
2019
- `./handsontable/languages/`
2120
6. Instead, edit the source files, located in the following directories:
2221
- `./handsontable/src/`
23-
- `./wrappers/angular/projects/hot-table/src/`
24-
- `./wrappers/react/src/`
25-
- `./wrappers/vue/src/`<br>
22+
- `./wrappers/angular-wrapper/projects/hot-table/src/`
23+
- `./wrappers/vue3/src/`<br>
2624
To check your changes, [make a build](https://handsontable.com/docs/building/), but don't commit your build files.
2725
7. For any change you make, add at least one test case. Your tests will help us understand the issue and make sure it stays fixed forever. Read more about our [testing process](https://handsontable.com/docs/testing/).<br>
2826
For the main Handsontable project, add your tests to one of the following directories:

‎docs/.vuepress/code-structure-builder/buildVueBody.js‎

Lines changed: 0 additions & 76 deletions
This file was deleted.

‎docs/.vuepress/code-structure-builder/getBody.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ const { buildAngularBody } = require('./buildAngularBody');
33
const { buildJavascriptBody } = require('./buildJavascriptBody');
44
const { buildReactBody } = require('./buildReactBody');
55
const { buildVue3Body } = require('./buildVue3Body');
6-
const { buildVueBody } = require('./buildVueBody');
76

87
const getBody = ({ id, html, js, css, docsVersion, preset, sandbox, lang, extraDeps = [] }) => {
98
const version = formatVersion(docsVersion);
@@ -35,8 +34,6 @@ const getBody = ({ id, html, js, css, docsVersion, preset, sandbox, lang, extraD
3534
});
3635
} else if (/vue3(-.*)?/.test(preset)) {
3736
return buildVue3Body({ id, html, js, css, version, hyperformulaVersion, preset });
38-
} else if (/vue(-.*)?/.test(preset)) {
39-
return buildVueBody({ id, html, js, css, version, hyperformulaVersion, preset });
4037
} else if (/angular(-.*)?/.test(preset)) {
4138
return buildAngularBody({ html, js, version, hyperformulaVersion });
4239
}

‎docs/.vuepress/containers/examples/add-code-for-preset.js‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ root.render(<${exportId} />);`;
3232
} else if (/vue3(-.*)?/.test(preset)) {
3333
return `const app = createApp(${exportId});
3434
app.mount('#${id}');`;
35-
} else if (/vue(-.*)?/.test(preset)) {
36-
return `new Vue({
37-
...${exportId},
38-
el: '#${id}',
39-
});`;
4035
} else if (/angular(-.*)?/.test(preset)) {
4136
return `import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
4237

0 commit comments

Comments
 (0)