Skip to content

Commit 8888877

Browse files
authored
Add fix to ESM, CJS build (#12013)
1 parent e43509c commit 8888877

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ jobs:
497497
- name: Test
498498
run: |
499499
cd handsontable
500-
npm run test:e2e.dump.esm-cjs && npm run test:e2e.puppeteer
500+
npm run test:e2e.dump.esm-cjs && npm run test:e2e.dump --theme=main && npm run test:e2e.puppeteer
501501
502502
test-handsontable-cjs-e2e:
503503
name: "[TEST] Handsontable: CJS"
@@ -539,7 +539,7 @@ jobs:
539539
- name: Test
540540
run: |
541541
cd handsontable
542-
npm run test:e2e.dump.esm-cjs && npm run test:e2e.puppeteer
542+
npm run test:e2e.dump.esm-cjs && npm run test:e2e.dump --theme=main && npm run test:e2e.puppeteer
543543
544544
test-angular:
545545
name: "[TEST] Wrapper: Angular"

handsontable/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"test:e2e.verbose": "npm run build:umd && npm run build:languages && npm run build:themes-umd && npm run test:e2e.dump --theme=main && npm run test:e2e.puppeteer -- --verbose",
4242
"test:e2e.watch": "node ./test/scripts/run-puppeteer-on-watchers-change.mjs --cmdToListen \"npm run watch\" --cmdToListen \"npm run test:e2e.dump --theme=main -- --watch\" --runnerFile \"test/E2ERunner.html\"",
4343
"test:e2e.dump": "npm run build:styles && cross-env-shell BABEL_ENV=commonjs_e2e NODE_ENV=test-e2e env-cmd -f ../hot.config.js webpack ./test/helpers/index.js ./test/e2e/index.js",
44-
"test:e2e.dump.esm-cjs": "npm run build:styles && cross-env-shell BABEL_ENV=commonjs_e2e NODE_ENV=test-e2e-esm-cjs env-cmd -f ../hot.config.js webpack ./test/helpers/index.js ./test/e2e/index.js",
44+
"test:e2e.dump.esm-cjs": "cross-env-shell BABEL_ENV=commonjs_e2e NODE_ENV=test-e2e-esm-cjs env-cmd -f ../hot.config.js webpack ./test/helpers/index.js ./test/e2e/index.js",
4545
"test:e2e.puppeteer": "node test/scripts/run-puppeteer.mjs test/E2ERunner.html",
4646
"test:unit": "npm run build:styles && cross-env-shell npm_config_testPathPattern=. BABEL_ENV=commonjs env-cmd -f ../hot.config.js jest --testPathPattern=$npm_config_testPathPattern",
4747
"test:unit.watch": "npm run build:styles && cross-env-shell BABEL_ENV=commonjs env-cmd -f ../hot.config.js jest --testPathPattern=$npm_config_testPathPattern --watch",
@@ -52,8 +52,8 @@
5252
"build:commonjs": "cross-env-shell BABEL_ENV=commonjs_dist env-cmd -f ../hot.config.js babel src --out-dir tmp",
5353
"build:es": "npm run build:styles && cross-env-shell BABEL_ENV=es env-cmd -f ../hot.config.js babel src --out-file-extension .mjs --out-dir tmp",
5454
"build:umd": "npm run build:all.styles && cross-env-shell BABEL_ENV=commonjs NODE_ENV=development env-cmd -f ../hot.config.js webpack ./src/index.js",
55-
"build:umd-from-esm": "cross-env-shell BABEL_ENV=commonjs NODE_ENV=development env-cmd -f ../hot.config.js webpack ./tmp/index.mjs",
56-
"build:umd-from-cjs": "cross-env-shell BABEL_ENV=commonjs NODE_ENV=development env-cmd -f ../hot.config.js webpack ./tmp/index.js",
55+
"build:umd-from-esm": "npm run build:all.styles && cross-env-shell BABEL_ENV=commonjs NODE_ENV=development env-cmd -f ../hot.config.js webpack ./tmp/index.mjs",
56+
"build:umd-from-cjs": "npm run build:all.styles && cross-env-shell BABEL_ENV=commonjs NODE_ENV=development env-cmd -f ../hot.config.js webpack ./tmp/index.js",
5757
"build:umd.min": "npm run build:all.styles.min && cross-env-shell BABEL_ENV=commonjs NODE_ENV=production env-cmd -f ../hot.config.js webpack ./src/index.js",
5858
"build:all.styles": "npm run build:styles && npm run build:themes-css",
5959
"build:all.styles.min": "npm run build:styles.min && npm run build:themes-css.min",

0 commit comments

Comments
 (0)