fix Tree#entryByName function and add test

novalis · novalis · commit 63f835e42bb2 · 2016-07-20T10:05:45.000-04:00
diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json
@@ -2499,9 +2499,7 @@
           "jsFunctionName": "_entryByIndex"
         },
         "git_tree_entry_byname": {
-          "return": {
-            "ownedByThis": true
-          }
+          "jsFunctionName": "_entryByName"
         },
         "git_tree_entrycount": {
           "jsFunctionName": "entryCount"
diff --git a/lib/tree.js b/lib/tree.js
@@ -65,7 +65,7 @@ Tree.prototype.entryByIndex = function(i) {
  * @return {TreeEntry}
  */
 Tree.prototype.entryByName = function(name) {
-  var entry = this.entryByName(name);
+  var entry = this._entryByName(name);
   entry.parent = this;
   return entry;
 };
diff --git a/test/tests/tree.js b/test/tests/tree.js
@@ -5,22 +5,40 @@ var promisify = require("promisify-node");
 var fse = promisify(require("fs-extra"));
 
 describe("Tree", function() {
+  var NodeGit = require("../../");
   var RepoUtils = require("../utils/repository_setup");
 
   var repoPath = local("../repos/tree");
+  var existingPath = local("../repos/workdir");
+  var oid = "5716e9757886eaf38d51c86b192258c960d9cfea";
 
   beforeEach(function() {
     var test = this;
     return RepoUtils.createRepository(repoPath)
       .then(function(repo) {
         test.repository = repo;
+      }).then(function() {
+        return NodeGit.Repository.open(existingPath);
+      }).then(function(repository) {
+        test.existingRepo = repository;
+        return repository.getCommit(oid);
+      }).then(function(commit) {
+        test.commit = commit;
       });
   });
 
   after(function() {
     return fse.remove(repoPath);
   });
 
+  it("gets an entry by name",
+  function(done) {
+    this.commit.getTree().then(function(tree) {
+      var entry = tree.entryByName("README.md");
+        assert(entry);
+    }).done(done);
+  });
+
   it("walks its entries and returns the same entries on both progress and end",
   function() {
     var repo = this.repository;
