Skip to content

Commit 85eb4d3

Browse files
committed
adding a better message email
1 parent 7971029 commit 85eb4d3

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

models/message.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class Message
1818

1919
def send_notification
2020
recipient_email = Hacker.first(:username => self.recipient).email
21-
Notifier.send_message_notification(recipient_email)
21+
Notifier.send_message_notification(recipient_email, self.sender)
2222
end
2323

2424
end

models/notifier.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
class Notifier
2-
def self.send_message_notification(recipient)
2+
def self.send_message_notification(recipient, who)
33
Pony.mail(:to => recipient,
44
:subject => "Hackety Hack: New Message",
55
:from => "steve+hackety@steveklabnik.com",
6-
:body => render_haml_template("message"),
6+
:body => render_haml_template("message", who),
77
:via => :smtp, :via_options => PONY_VIA_OPTIONS)
88
end
99

1010
private
1111

12-
def self.render_haml_template(template)
13-
engine = Haml::Engine.new(File.open("views/notifier/#{template}.haml", "rb").read)
12+
def self.render_haml_template(template, who)
13+
engine = Haml::Engine.new(File.open("views/notifier/#{template}.haml", "rb").read, :who => who)
1414
engine.render
1515
end
1616
end

views/notifier/message.haml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,5 @@
1-
The Hackety Hack Robot
1+
Hey there! You have a new message on the Hackety Hack site from #{@who}! You can check it out here:
2+
3+
http://hackety-hack.com/messages
4+
5+
\- The Hackety Hack Robot

0 commit comments

Comments
 (0)