Making tests more meaningful by introducing another user that can be followed/follow someone fixes #127

PragTob · PragTob · commit 597d08323717 · 2012-03-09T21:30:22.000+01:00
diff --git a/features/step_definitions/user_steps.rb b/features/step_definitions/user_steps.rb
@@ -1,14 +1,21 @@
 def login_user
    @user = User.create!(username:              "test_user",
-                       email:                 "test_user@example.com",
-                       password:              "foobar",
-                       password_confirmation: "foobar")
+                        email:                 "test_user@example.com",
+                        password:              "foobar",
+                        password_confirmation: "foobar")
   visit login_path
   fill_in("Username", :with => @user.username)
   fill_in("Password", :with => @user.password)
   click_button("Sign in")
 end
 
+def create_other_user
+  @other_user = User.create!(username:              "other_user",
+                             email:                 "other_user@example.com",
+                             password:              "123456",
+                             password_confirmation: "123456")
+end
+
 Given /^a logged in user$/ do
   login_user unless @user
 end
@@ -29,6 +36,16 @@ def login_user
   click_button "Update"
 end
 
+When /^I have a follower$/ do
+  create_other_user
+  @other_user.follow! @user
+end
+
+When /^I am following someone$/ do
+  create_other_user
+  @user.follow! @other_user
+end
+
 When /^I click on the number of followers on my profile$/ do
   step 'I go to look at my profile page'
   first('.user-followers').click
@@ -39,12 +56,12 @@ def login_user
   first('.user-following').click
 end
 
-Then /^I should see a list of the people I'm following$/ do
-  page.should have_content "#{@user.username} is following"
+Then /^I should see someone I'm following$/ do
+  page.should have_link @other_user.username
 end
 
-Then /^I should see a list of my followers$/ do
-  page.should have_content "#{@user.username}'s followers"
+Then /^I should see my follower$/ do
+  page.should have_link @other_user.username
 end
 
 Then /^I should be notified that my profile was updated$/ do
diff --git a/features/users.feature b/features/users.feature
@@ -15,10 +15,12 @@ Feature: Manage account
     And I should see my changes reflected on my profile page
 
   Scenario: See my followers
-    When I click on the number of followers on my profile
-    Then I should see a list of my followers
+    When I have a follower
+    And I click on the number of followers on my profile
+    Then I should see my follower
 
-  Scenario: See who is following me
-    When I click on the number of people I am following on my profile
-    Then I should see a list of the people I'm following
+  Scenario: See who I am following
+    When I am following someone
+    And I click on the number of people I am following on my profile
+    Then I should see someone I'm following
 
