Skip to content

Commit cdf4186

Browse files
authored
[PSM Interop] Legacy tests: fix xDS test client build (v1.53.x backport) (#33810)
Backport of #33796 to v1.53.x. --- #33699 incorrectly changed the legacy builds to not just use the test driver from the master, but also to build from it. This PR fixes the issue, and also updates the python job to work use the driver from master.
1 parent ce5b93a commit cdf4186

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

tools/internal_ci/linux/grpc_xds_bazel_python_test_in_docker.sh

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@
1616
trap 'date' DEBUG
1717
set -ex -o igncr || set -ex
1818

19+
1920
mkdir -p /var/local/git
20-
git clone /var/local/jenkins/grpc /var/local/git/grpc
21-
(cd /var/local/jenkins/grpc/ && git submodule foreach 'cd /var/local/git/grpc \
22-
&& git submodule update --init --reference /var/local/jenkins/grpc/${name} \
23-
${name}')
21+
git clone -b master --single-branch --depth=1 https://github.com/grpc/grpc.git /var/local/git/grpc
2422
cd /var/local/git/grpc
2523

2624
python3 -m pip install virtualenv
@@ -62,13 +60,14 @@ touch "$TOOLS_DIR"/src/proto/grpc/health/v1/__init__.py
6260
--grpc_python_out=${TOOLS_DIR} \
6361
${HEALTH_PROTO_SOURCE_DIR}/health.proto
6462

63+
cd /var/local/jenkins/grpc/
6564
bazel build //src/python/grpcio_tests/tests_py3_only/interop:xds_interop_client
6665

6766
# Test cases "path_matching" and "header_matching" are not included in "all",
6867
# because not all interop clients in all languages support these new tests.
6968
export PYTHONUNBUFFERED=true
7069
GRPC_VERBOSITY=debug GRPC_TRACE=xds_client,xds_resolver,xds_cluster_manager_lb,cds_lb,xds_cluster_resolver_lb,priority_lb,xds_cluster_impl_lb,weighted_target_lb "$PYTHON" \
71-
tools/run_tests/run_xds_tests.py \
70+
/var/local/git/grpc/tools/run_tests/run_xds_tests.py \
7271
--halt_after_fail \
7372
--test_case="ping_pong,circuit_breaking" \
7473
--project_id=grpc-testing \

tools/internal_ci/linux/grpc_xds_bazel_test_in_docker.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ touch "$TOOLS_DIR"/src/proto/grpc/health/v1/__init__.py
5959
--grpc_python_out=${TOOLS_DIR} \
6060
${HEALTH_PROTO_SOURCE_DIR}/health.proto
6161

62+
cd /var/local/jenkins/grpc/
6263
bazel build test/cpp/interop:xds_interop_client
6364

6465
# Test cases "path_matching" and "header_matching" are not included in "all",
@@ -67,7 +68,7 @@ bazel build test/cpp/interop:xds_interop_client
6768
# TODO: remove "path_matching" and "header_matching" from --test_case after
6869
# they are added into "all".
6970
GRPC_VERBOSITY=debug GRPC_TRACE=xds_client,xds_resolver,xds_cluster_manager_lb,cds_lb,xds_cluster_resolver_lb,priority_lb,xds_cluster_impl_lb,weighted_target_lb "$PYTHON" \
70-
tools/run_tests/run_xds_tests.py \
71+
/var/local/git/grpc/tools/run_tests/run_xds_tests.py \
7172
--halt_after_fail \
7273
--test_case="ping_pong,circuit_breaking" \
7374
--project_id=grpc-testing \

0 commit comments

Comments
 (0)