Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/google-cloud-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: grobie/google-cloud-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 7, 2025

  1. fix(trace): Correctly normalize inconsistent ActiveSupport timestamps 

    The `normalize_time` method in the google-cloud-trace library produced
incorrect timestamps when used with certain versions of Rails 7 and with
Rails 8.

Because this change was not consistent across all versions and was
altered silently (e.g., rails/rails#50779),
a simple version check is unreliable. The previous implementation
incorrectly assumed any numeric timestamp was in milliseconds, causing
faulty time conversions and leading to trace spans being dropped by the
API.

It now uses a numeric threshold to reliably differentiate between
timestamps in seconds and milliseconds, ensuring correct handling
regardless of the specific Rails version.

Fixes #30798.
    @grobie
    grobie committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    e234045 View commit details
    Browse the repository at this point in the history
Loading