From 7e98d67169e2a7ee2ceb6487a3fcd9a1da671a22 Mon Sep 17 00:00:00 2001 From: danwchan Date: Sat, 20 Jan 2018 22:37:05 -0400 Subject: [PATCH 1/3] tweaked the tuple lesson for greater clarity --- python2/koans/about_tuples.py | 3 ++- python3/koans/about_tuples.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/python2/koans/about_tuples.py b/python2/koans/about_tuples.py index 84ba5d552..7ef9a886d 100644 --- a/python2/koans/about_tuples.py +++ b/python2/koans/about_tuples.py @@ -41,7 +41,8 @@ def test_tuples_can_only_be_changed_through_replacement(self): def test_tuples_of_one_look_peculiar(self): self.assertEqual(__, (1).__class__) self.assertEqual(__, (1,).__class__) - self.assertEqual(__, ("Hello comma!", )) + self.assertEqual(__, ("I'm a tuple",)) + self.assertEqual(__, ("Not a tuple")) def test_tuple_constructor_can_be_surprising(self): self.assertEqual(__, tuple("Surprise!")) diff --git a/python3/koans/about_tuples.py b/python3/koans/about_tuples.py index cc6ac5291..35a8e4a63 100644 --- a/python3/koans/about_tuples.py +++ b/python3/koans/about_tuples.py @@ -39,7 +39,8 @@ def test_tuples_can_only_be_changed_through_replacement(self): def test_tuples_of_one_look_peculiar(self): self.assertEqual(__, (1).__class__) self.assertEqual(__, (1,).__class__) - self.assertEqual(__, ("Hello comma!", )) + self.assertEqual(__, ("I'm a tuple",)) + self.assertEqual(__, ("Not a tuple")) def test_tuple_constructor_can_be_surprising(self): self.assertEqual(__, tuple("Surprise!")) From 8fd7a8d8b701dc0be8a5f2da8c2acf1db3dcbfa3 Mon Sep 17 00:00:00 2001 From: Danny Date: Sun, 28 Jan 2018 14:29:32 -0400 Subject: [PATCH 2/3] A place to rework later after you figure out more --- python3/koans/about_decorating_with_classes.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python3/koans/about_decorating_with_classes.py b/python3/koans/about_decorating_with_classes.py index 00bd5fe90..92e7a815c 100644 --- a/python3/koans/about_decorating_with_classes.py +++ b/python3/koans/about_decorating_with_classes.py @@ -68,7 +68,8 @@ def test_decorator_with_no_arguments(self): self.assertEqual(__, self.parrot('pieces of eight')) # ------------------------------------------------------------------ - + # I think this cold be reworked with the previous lesson about decorating with functions + def sound_check(self): #Note: no decorator return "Testing..." From ad71ca10f6dfa5b18710e8cc983ffcd6926f6fc7 Mon Sep 17 00:00:00 2001 From: Danny Date: Mon, 12 Feb 2018 19:17:08 -0400 Subject: [PATCH 3/3] removed that stray comment from the pull --- python3/koans/about_decorating_with_classes.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/python3/koans/about_decorating_with_classes.py b/python3/koans/about_decorating_with_classes.py index 92e7a815c..00bd5fe90 100644 --- a/python3/koans/about_decorating_with_classes.py +++ b/python3/koans/about_decorating_with_classes.py @@ -68,8 +68,7 @@ def test_decorator_with_no_arguments(self): self.assertEqual(__, self.parrot('pieces of eight')) # ------------------------------------------------------------------ - # I think this cold be reworked with the previous lesson about decorating with functions - + def sound_check(self): #Note: no decorator return "Testing..."