SchemaClassScanner doesn't scan directive arguments #664

Activity

1. oryan-block

   added

   bug

   on May 19, 2022
2. enriquedacostacambio commented on Aug 25, 2022

   

   enriquedacostacambio

   on Aug 25, 2022

   More actions

   This causes apollo-federated schemas to fail because _FieldSet is only used in directives.

   Caused by: graphql.kickstart.tools.SchemaError: Expected type '_FieldSet' to be a GraphQLInputType, but it wasn't!  Was a type only permitted for object types incorrectly used as an input type, or vice-versa?
   	at graphql.kickstart.tools.SchemaParser.determineType(SchemaParser.kt:355) ~[graphql-java-tools-13.0.0.jar:na]
   	at graphql.kickstart.tools.SchemaParser.determineInputType(SchemaParser.kt:373) ~[graphql-java-tools-13.0.0.jar:na]
   	at graphql.kickstart.tools.SchemaParser.determineInputType(SchemaParser.kt:365) ~[graphql-java-tools-13.0.0.jar:na]
   	at graphql.kickstart.tools.SchemaParser.createDirective(SchemaParser.kt:307) ~[graphql-java-tools-13.0.0.jar:na]
   	at graphql.kickstart.tools.SchemaParser.parseSchemaObjects(SchemaParser.kt:83) ~[graphql-java-tools-13.0.0.jar:na]
   	at graphql.kickstart.tools.SchemaParser.makeExecutableSchema(SchemaParser.kt:110) ~[graphql-java-tools-13.0.0.jar:na]
   
3. enriquedacostacambio commented on Sep 7, 2022

   

   enriquedacostacambio

   on Sep 7, 2022

   Last edited by enriquedacostacambio

   More actions

   this can be reproduced with:

   package test;
   
   import java.util.stream.Collectors;
   import java.util.stream.Stream;
   
   import org.junit.Test;
   
   import graphql.GraphQL;
   import graphql.kickstart.tools.GraphQLQueryResolver;
   import graphql.kickstart.tools.SchemaParser;
   import graphql.kickstart.tools.SchemaParserBuilder;
   import graphql.scalar.GraphqlStringCoercing;
   import graphql.schema.DataFetchingEnvironment;
   import graphql.schema.GraphQLScalarType;
   import graphql.schema.GraphQLSchema;
   
   public class IssueTest {
       static class MockQueryResolver implements GraphQLQueryResolver {
           public String mockField(String input, DataFetchingEnvironment environment) {
               return null;
           }
       };
       
       @Test
       public void testUsedInField() {
           // this passes
           graphQl(
               "scalar MockScalar",
               "directive @mockDirective(arg: MockScalar) on FIELD_DEFINITION",
               "type Query {",
               "    mockField(input: MockScalar): String @mockDirective(arg: \"mock-value\")",
               "}"
           );
       }
       
       @Test
       public void testUsedOnlyInDirectives() {
           // this fails with:
           // graphql.kickstart.tools.SchemaError: Expected type 'MockScalar' to be
           // a GraphQLInputType, but it wasn't!  Was a type only permitted for
           // object types incorrectly used as an input type, or vice-versa?
           graphQl(
               "scalar MockScalar",
               "directive @mockDirective(arg: MockScalar) on FIELD_DEFINITION",
               "type Query {",
               "    mockField(input: String) : String @mockDirective(arg: \"mock-value\")",
               "}"
           );
       }
       
       private GraphQL graphQl(String... sdl) {
           SchemaParserBuilder builder = new SchemaParserBuilder();
           builder.schemaString(Stream.of(sdl).collect(Collectors.joining("\n")));
           SchemaParser schemaParser = builder
               .resolvers(new MockQueryResolver())
               .scalars(GraphQLScalarType.newScalar()
                   .name("MockScalar")
                   .coercing(new GraphqlStringCoercing())
                   .build()
               )
               .build();
           GraphQLSchema schema = schemaParser.makeExecutableSchema();
           return GraphQL.newGraphQL(schema).build();
       }
   }
4. enriquedacostacambio commented on Sep 30, 2022

   

   enriquedacostacambio

   on Sep 30, 2022

   More actions

   @oryan-block is this easy to fix? i never coded in kotlin but if you give me a few pointers I can give it a shot.
5. oryan-block commented on Oct 3, 2022

   

   oryan-block

   on Oct 3, 2022

   CollaboratorAuthor

   More actions

   Unfortunately because of the way the scanner works and how different directives are from everything else, this is not a trivial fix.
6. anbusampath commented on Dec 6, 2022

   

   anbusampath

   on Dec 6, 2022

   More actions

   #725
7. oryan-block

   closed this as completedin #763on Sep 18, 2023
8. oryan-block commented on Sep 18, 2023

   

   oryan-block

   on Sep 18, 2023

   CollaboratorAuthor

   More actions

   This should be partially resolved by #763 for scalars.
   However, directives with input object arguments/parameters are still not supported (this was the case even before the applied directives change)
9. oryan-block

   reopened this on Sep 18, 2023
10. airvine-r7 commented on Sep 20, 2023

    

    airvine-r7

    on Sep 20, 2023

    More actions

    @oryan-block Any updates on this or work arounds?

    This should be partially resolved by #763 for scalars. However, directives with input object arguments/parameters are still not supported (this was the case even before the applied directives change)
11. oryan-block commented on Sep 20, 2023

    

    oryan-block

    on Sep 20, 2023

    CollaboratorAuthor

    More actions

    @airvine-r7 that fix is merged. You can test it now.
    #764 is a more complete solution I think should make directives fully supported.

    👍React with 👍1Reacted by airvine-r7
12. oryan-block

    closed this as completedin #764on Sep 20, 2023