Capture partial results on cancellation#4398
Open
AlexandreCarlton wants to merge 1 commit into
Open
Conversation
Web clients can often impose request timeouts. If a GraphQL server takes too long to respond, then nothing is returned. While we can call `ExecutionInput.cancel()` in order to slide a web client's timeout, there are no usable results for the client to use. This change improves on this - if we set `#capturePartialResultsOnCancel`, then calling `.cancel` will save all the evaluated `DataFetcher` results so that something potentially usable can be returned to the client. Full disclosure: almost all of this was generated with Rovo, with a preliminary review from Brad before submitting here.
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (8 classes)
AbstractAsyncExecutionStrategy — method details
Async.Many — method details
AsyncExecutionStrategy — method details
ExecutionStrategy — method details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web clients can often impose request timeouts. If a GraphQL server takes too long to respond, then nothing is returned. While we can call
ExecutionInput.cancel()in order to slide under a web client's timeout, there are no usable results for the client to handle.This change improves upon this - if we set
#capturePartialResultsOnCancel, then calling.cancelwill save all the evaluatedDataFetcherresults so that something potentially usable can be returned to the client.Full disclosure: almost all of this was generated with Rovo, with a preliminary review from @bbakerman before submitting here.