Replace @experimental_disableErrorPropagation with onError parameter#4378
Draft
martinbonnin wants to merge 2 commits into
Draft
Replace @experimental_disableErrorPropagation with onError parameter#4378martinbonnin wants to merge 2 commits into
@experimental_disableErrorPropagation with onError parameter#4378martinbonnin wants to merge 2 commits into
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (1 class)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this as a heads up: see graphql/graphql-spec#1163
Not sure we want to merge is now since it's not in graphql-js yet and the
@experimental_disableErrorPropagationdirective still gets the job done for now. But looks like this is the direction we're taking.