diff --git a/src/main/java/graphql/analysis/QueryComplexityInfo.java b/src/main/java/graphql/analysis/QueryComplexityInfo.java index f4e86d0be1..29914e960a 100644 --- a/src/main/java/graphql/analysis/QueryComplexityInfo.java +++ b/src/main/java/graphql/analysis/QueryComplexityInfo.java @@ -3,6 +3,7 @@ import graphql.PublicApi; import graphql.execution.instrumentation.parameters.InstrumentationExecuteOperationParameters; import graphql.execution.instrumentation.parameters.InstrumentationValidationParameters; +import org.jspecify.annotations.NullUnmarked; /** * The query complexity info. @@ -62,6 +63,7 @@ public static Builder newQueryComplexityInfo() { } @PublicApi + @NullUnmarked public static class Builder { private int complexity; diff --git a/src/main/java/graphql/analysis/QueryDepthInfo.java b/src/main/java/graphql/analysis/QueryDepthInfo.java index 38550b4e01..a8d4a0ac03 100644 --- a/src/main/java/graphql/analysis/QueryDepthInfo.java +++ b/src/main/java/graphql/analysis/QueryDepthInfo.java @@ -1,6 +1,7 @@ package graphql.analysis; import graphql.PublicApi; +import org.jspecify.annotations.NullUnmarked; /** * The query depth info. @@ -38,6 +39,7 @@ public static Builder newQueryDepthInfo() { } @PublicApi + @NullUnmarked public static class Builder { private int depth; diff --git a/src/main/java/graphql/analysis/QueryTransformer.java b/src/main/java/graphql/analysis/QueryTransformer.java index eed41818e9..f1a22df186 100644 --- a/src/main/java/graphql/analysis/QueryTransformer.java +++ b/src/main/java/graphql/analysis/QueryTransformer.java @@ -13,6 +13,7 @@ import java.util.LinkedHashMap; import java.util.Map; +import org.jspecify.annotations.NullUnmarked; import static graphql.Assert.assertNotNull; import static graphql.language.AstNodeAdapter.AST_NODE_ADAPTER; @@ -98,6 +99,7 @@ public static Builder newQueryTransformer() { } @PublicApi + @NullUnmarked public static class Builder { private GraphQLSchema schema; private Map variables; diff --git a/src/main/java/graphql/analysis/QueryTraverser.java b/src/main/java/graphql/analysis/QueryTraverser.java index 2f543e5b43..c0ace1082f 100644 --- a/src/main/java/graphql/analysis/QueryTraverser.java +++ b/src/main/java/graphql/analysis/QueryTraverser.java @@ -23,6 +23,7 @@ import java.util.List; import java.util.Locale; import java.util.Map; +import org.jspecify.annotations.NullUnmarked; import static graphql.Assert.assertNotNull; import static graphql.Assert.assertShouldNeverHappen; @@ -215,6 +216,7 @@ public static Builder newQueryTraverser() { } @PublicApi + @NullUnmarked public static class Builder { private GraphQLSchema schema; private Document document; diff --git a/src/main/java/graphql/language/NodeDirectivesBuilder.java b/src/main/java/graphql/language/NodeDirectivesBuilder.java index d7a7ee7214..3694165fab 100644 --- a/src/main/java/graphql/language/NodeDirectivesBuilder.java +++ b/src/main/java/graphql/language/NodeDirectivesBuilder.java @@ -10,6 +10,4 @@ public interface NodeDirectivesBuilder extends NodeBuilder { NodeDirectivesBuilder directives(List directives); NodeDirectivesBuilder directive(Directive directive); - - } diff --git a/src/main/java/graphql/schema/GraphQLEnumValueDefinition.java b/src/main/java/graphql/schema/GraphQLEnumValueDefinition.java index 4aba114c7b..ec9529e34b 100644 --- a/src/main/java/graphql/schema/GraphQLEnumValueDefinition.java +++ b/src/main/java/graphql/schema/GraphQLEnumValueDefinition.java @@ -12,6 +12,7 @@ import java.util.List; import java.util.Map; import java.util.function.Consumer; +import org.jspecify.annotations.NullUnmarked; import static graphql.Assert.assertNotNull; import static graphql.Assert.assertValidName; @@ -193,6 +194,7 @@ public static Builder newEnumValueDefinition(GraphQLEnumValueDefinition existing } @PublicApi + @NullUnmarked public static class Builder extends GraphqlDirectivesContainerTypeBuilder { private Object value; private String deprecationReason; diff --git a/src/main/java/graphql/schema/GraphQLFieldDefinition.java b/src/main/java/graphql/schema/GraphQLFieldDefinition.java index 991da1793d..0d2452b119 100644 --- a/src/main/java/graphql/schema/GraphQLFieldDefinition.java +++ b/src/main/java/graphql/schema/GraphQLFieldDefinition.java @@ -15,6 +15,7 @@ import java.util.List; import java.util.Map; import java.util.function.Consumer; +import org.jspecify.annotations.NullUnmarked; import java.util.function.UnaryOperator; import static graphql.Assert.assertNotNull; @@ -256,6 +257,7 @@ public static Builder newFieldDefinition() { } @PublicApi + @NullUnmarked public static class Builder extends GraphqlDirectivesContainerTypeBuilder { private GraphQLOutputType type; diff --git a/src/main/java/graphql/schema/GraphQLInputObjectField.java b/src/main/java/graphql/schema/GraphQLInputObjectField.java index 14ce1cf591..13488d9b95 100644 --- a/src/main/java/graphql/schema/GraphQLInputObjectField.java +++ b/src/main/java/graphql/schema/GraphQLInputObjectField.java @@ -15,6 +15,7 @@ import java.util.Locale; import java.util.Map; import java.util.function.Consumer; +import org.jspecify.annotations.NullUnmarked; import static graphql.Assert.assertNotNull; import static graphql.Assert.assertValidName; @@ -266,6 +267,7 @@ public static Builder newInputObjectField() { } @PublicApi + @NullUnmarked public static class Builder extends GraphqlDirectivesContainerTypeBuilder { private InputValueWithState defaultValue = InputValueWithState.NOT_SET; private GraphQLInputType type; diff --git a/src/main/java/graphql/schema/GraphQLInputObjectType.java b/src/main/java/graphql/schema/GraphQLInputObjectType.java index e10eddadb7..f5d15999e2 100644 --- a/src/main/java/graphql/schema/GraphQLInputObjectType.java +++ b/src/main/java/graphql/schema/GraphQLInputObjectType.java @@ -19,6 +19,7 @@ import java.util.List; import java.util.Map; import java.util.function.Consumer; +import org.jspecify.annotations.NullUnmarked; import java.util.function.UnaryOperator; import static graphql.Assert.assertNotNull; @@ -253,6 +254,7 @@ public static Builder newInputObject() { } @PublicApi + @NullUnmarked public static class Builder extends GraphqlDirectivesContainerTypeBuilder { private InputObjectTypeDefinition definition; private List extensionDefinitions = emptyList(); diff --git a/src/main/java/graphql/schema/GraphQLInterfaceType.java b/src/main/java/graphql/schema/GraphQLInterfaceType.java index 5dff23c40a..dac766288e 100644 --- a/src/main/java/graphql/schema/GraphQLInterfaceType.java +++ b/src/main/java/graphql/schema/GraphQLInterfaceType.java @@ -17,6 +17,7 @@ import java.util.List; import java.util.Map; import java.util.function.Consumer; +import org.jspecify.annotations.NullUnmarked; import java.util.function.UnaryOperator; import static graphql.Assert.assertNotNull; @@ -258,6 +259,7 @@ public static Builder newInterface(GraphQLInterfaceType existing) { @PublicApi + @NullUnmarked public static class Builder extends GraphqlDirectivesContainerTypeBuilder { private TypeResolver typeResolver; private InterfaceTypeDefinition definition; diff --git a/src/main/java/graphql/schema/GraphQLObjectType.java b/src/main/java/graphql/schema/GraphQLObjectType.java index f6104266a4..dfba44b805 100644 --- a/src/main/java/graphql/schema/GraphQLObjectType.java +++ b/src/main/java/graphql/schema/GraphQLObjectType.java @@ -17,6 +17,7 @@ import java.util.List; import java.util.Map; import java.util.function.Consumer; +import org.jspecify.annotations.NullUnmarked; import java.util.function.UnaryOperator; import static graphql.Assert.assertNotNull; @@ -247,6 +248,7 @@ public static Builder newObject(GraphQLObjectType existing) { } @PublicApi + @NullUnmarked public static class Builder extends GraphqlDirectivesContainerTypeBuilder { private ObjectTypeDefinition definition; private List extensionDefinitions = emptyList(); diff --git a/src/main/java/graphql/schema/GraphQLScalarType.java b/src/main/java/graphql/schema/GraphQLScalarType.java index fccfb0013b..bf5442cda9 100644 --- a/src/main/java/graphql/schema/GraphQLScalarType.java +++ b/src/main/java/graphql/schema/GraphQLScalarType.java @@ -14,6 +14,7 @@ import java.util.List; import java.util.Map; import java.util.function.Consumer; +import org.jspecify.annotations.NullUnmarked; import static graphql.Assert.assertNotNull; import static graphql.Assert.assertValidName; @@ -214,6 +215,7 @@ public static Builder newScalar(GraphQLScalarType existing) { @PublicApi + @NullUnmarked public static class Builder extends GraphqlDirectivesContainerTypeBuilder { private Coercing coercing; private ScalarTypeDefinition definition; diff --git a/src/main/java/graphql/schema/GraphQLUnionType.java b/src/main/java/graphql/schema/GraphQLUnionType.java index 6910084afd..23a7e9f195 100644 --- a/src/main/java/graphql/schema/GraphQLUnionType.java +++ b/src/main/java/graphql/schema/GraphQLUnionType.java @@ -16,6 +16,7 @@ import java.util.List; import java.util.Map; import java.util.function.Consumer; +import org.jspecify.annotations.NullUnmarked; import static graphql.Assert.assertNotEmpty; import static graphql.Assert.assertNotNull; @@ -249,6 +250,7 @@ public static Builder newUnionType(GraphQLUnionType existing) { } @PublicApi + @NullUnmarked public static class Builder extends GraphqlDirectivesContainerTypeBuilder { private TypeResolver typeResolver; private UnionTypeDefinition definition; diff --git a/src/main/java/graphql/schema/idl/RuntimeWiring.java b/src/main/java/graphql/schema/idl/RuntimeWiring.java index 42c4894e2a..88bdfc4cd1 100644 --- a/src/main/java/graphql/schema/idl/RuntimeWiring.java +++ b/src/main/java/graphql/schema/idl/RuntimeWiring.java @@ -16,6 +16,7 @@ import java.util.Map; import java.util.function.Consumer; import java.util.function.UnaryOperator; +import org.jspecify.annotations.NullUnmarked; import static graphql.Assert.assertNotNull; import static graphql.schema.visibility.DefaultGraphqlFieldVisibility.DEFAULT_FIELD_VISIBILITY; @@ -175,6 +176,7 @@ public GraphqlTypeComparatorRegistry getComparatorRegistry() { } @PublicApi + @NullUnmarked public static class Builder { private final Map> dataFetchers = new LinkedHashMap<>(); private final Map defaultDataFetchers = new LinkedHashMap<>(); diff --git a/src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy b/src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy index c32efb2826..95dc0cc435 100644 --- a/src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy +++ b/src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy @@ -35,15 +35,11 @@ class JSpecifyAnnotationsCheck extends Specification { "graphql.analysis.MaxQueryDepthInstrumentation", "graphql.analysis.QueryComplexityCalculator", "graphql.analysis.QueryComplexityInfo", - "graphql.analysis.QueryComplexityInfo\$Builder", "graphql.analysis.QueryDepthInfo", - "graphql.analysis.QueryDepthInfo\$Builder", "graphql.analysis.QueryReducer", "graphql.analysis.QueryTransformer", - "graphql.analysis.QueryTransformer\$Builder", "graphql.analysis.QueryTraversalOptions", "graphql.analysis.QueryTraverser", - "graphql.analysis.QueryTraverser\$Builder", "graphql.analysis.QueryVisitor", "graphql.analysis.QueryVisitorFieldArgumentEnvironment", "graphql.analysis.QueryVisitorFieldArgumentInputValue", @@ -240,21 +236,16 @@ class JSpecifyAnnotationsCheck extends Specification { "graphql.schema.GraphQLDirectiveContainer", "graphql.schema.GraphQLEnumType", "graphql.schema.GraphQLEnumValueDefinition", - "graphql.schema.GraphQLEnumValueDefinition\$Builder", "graphql.schema.GraphQLFieldDefinition", - "graphql.schema.GraphQLFieldDefinition\$Builder", "graphql.schema.GraphQLFieldsContainer", "graphql.schema.GraphQLImplementingType", "graphql.schema.GraphQLInputFieldsContainer", "graphql.schema.GraphQLInputObjectField", - "graphql.schema.GraphQLInputObjectField\$Builder", "graphql.schema.GraphQLInputObjectType", - "graphql.schema.GraphQLInputObjectType\$Builder", "graphql.schema.GraphQLInputSchemaElement", "graphql.schema.GraphQLInputType", "graphql.schema.GraphQLInputValueDefinition", "graphql.schema.GraphQLInterfaceType", - "graphql.schema.GraphQLInterfaceType\$Builder", "graphql.schema.GraphQLList", "graphql.schema.GraphQLModifiedType", "graphql.schema.GraphQLNamedInputType", @@ -264,10 +255,8 @@ class JSpecifyAnnotationsCheck extends Specification { "graphql.schema.GraphQLNonNull", "graphql.schema.GraphQLNullableType", "graphql.schema.GraphQLObjectType", - "graphql.schema.GraphQLObjectType\$Builder", "graphql.schema.GraphQLOutputType", "graphql.schema.GraphQLScalarType", - "graphql.schema.GraphQLScalarType\$Builder", "graphql.schema.GraphQLSchema", "graphql.schema.GraphQLSchemaElement", "graphql.schema.GraphQLType", @@ -276,7 +265,6 @@ class JSpecifyAnnotationsCheck extends Specification { "graphql.schema.GraphQLTypeVisitor", "graphql.schema.GraphQLTypeVisitorStub", "graphql.schema.GraphQLUnionType", - "graphql.schema.GraphQLUnionType\$Builder", "graphql.schema.GraphQLUnmodifiedType", "graphql.schema.GraphqlElementParentTree", "graphql.schema.GraphqlTypeComparatorEnvironment", @@ -302,7 +290,6 @@ class JSpecifyAnnotationsCheck extends Specification { "graphql.schema.idl.MapEnumValuesProvider", "graphql.schema.idl.NaturalEnumValuesProvider", "graphql.schema.idl.RuntimeWiring", - "graphql.schema.idl.RuntimeWiring\$Builder", "graphql.schema.idl.SchemaDirectiveWiring", "graphql.schema.idl.SchemaDirectiveWiringEnvironment", "graphql.schema.idl.SchemaGenerator",