Repository navigation
Null assertion error when a null Locale is set into Validation code #2907
Description
Describe the bug
I'm writing this down as a note but will fill in more information has it comes.
I've just upgraded from 18.2 to 19.0 and am not experiencing a number of errors that look like I'm getting a ton of errors of the form
=> graphql.AssertException: Object required to be not null
graphql.Assert.assertNotNull(Assert.java:31)
graphql.i18n.I18n.<init>(I18n.java:37)
graphql.i18n.I18n.i18n(I18n.java:46)
graphql.validation.Validator.validateDocument(Validator.java:68)
graphql.ParseAndValidate.validate(ParseAndValidate.java:111)
graphql.GraphQL.validate(GraphQL.java:628)
graphql.GraphQL.parseAndValidate(GraphQL.java:591)
graphql.GraphQL.lambda$parseValidateAndExecute$10(GraphQL.java:555)
graphql.execution.preparsed.NoOpPreparsedDocumentProvider.getDocument(NoOpPreparsedDocumentProvider.java:15)
graphql.execution.preparsed.PreparsedDocumentProvider.getDocumentAsync(PreparsedDocumentProvider.java:4
looking through the changelog this most likely relates to #2878
it looks like this is failing on a null locale --
To Reproduce
Please provide a code example or even better a test to reproduce the bug.
Activity
softprops commentedon Aug 1, 2022
I think the problem lie here with
executionInput.getLocale()which may be nullgraphql-java/src/main/java/graphql/GraphQL.java
Line 628 in 35ff68d
passing that along up the chain off calls will eventually nullable to the the runtime error
assertNotNull(locale);emitsbbakerman commentedon Aug 1, 2022
Yeah the problem here is the locale is indeed nul..
ExecutionInputwas indeed changed to default it during its builderprivate Locale locale = Locale.getDefault();but its possible for a caller to have set it to null (perhaps through calling some other method likecustomCode.getLocale()returning null.We need to default this at the call site.
As a work around until this gets fixed, people seeing this should ensure that a non null
Localeis set into theirExecutionInput[-]unclear breaking change in 19.0 update[/-][+]Null assertion error when a null Locale is set into Validation code[/+]