Skip to content

Commit fc2ec3e

Browse files
committed
remove not usable public constructor
1 parent ac32273 commit fc2ec3e

File tree

2 files changed

+2
-30
lines changed

2 files changed

+2
-30
lines changed

src/main/java/graphql/ExecutionInput.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,14 @@ public class ExecutionInput {
2626
private final ExecutionId executionId;
2727

2828

29-
public ExecutionInput(String query, String operationName, Object context, Object root, Map<String, Object> variables) {
30-
this(query, operationName, context, root, variables, new DataLoaderRegistry(), null, null);
31-
}
32-
3329
@Internal
3430
private ExecutionInput(String query, String operationName, Object context, Object root, Map<String, Object> variables, DataLoaderRegistry dataLoaderRegistry, CacheControl cacheControl, ExecutionId executionId) {
3531
this.query = assertNotNull(query, "query can't be null");
3632
this.operationName = operationName;
3733
this.context = context;
3834
this.root = root;
39-
this.variables = assertNotNull(variables, "variables map can't be null");
35+
this.variables = variables;
36+
// this.variables = assertNotNull(variables, "variables map can't be null");
4037
this.dataLoaderRegistry = dataLoaderRegistry;
4138
this.cacheControl = cacheControl;
4239
this.executionId = executionId;

src/test/groovy/graphql/GraphQLTest.groovy

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -987,19 +987,6 @@ many lines''']
987987
assEx.message.contains("variables map can't be null")
988988
989989
990-
}
991-
992-
def "variables map can't be null via ExecutionInput constructor"() {
993-
given:
994-
995-
when:
996-
new ExecutionInput("query", "opName", null, null, null);
997-
998-
then:
999-
def assEx = thrown(AssertException)
1000-
assEx.message.contains("variables map can't be null")
1001-
1002-
1003990
}
1004991
1005992
def "query can't be null via ExecutionInput"() {
@@ -1028,16 +1015,4 @@ many lines''']
10281015
10291016
}
10301017
1031-
def "query can't be null via ExecutionInput constructor"() {
1032-
given:
1033-
1034-
when:
1035-
new ExecutionInput(null, "opName", null, null, null);
1036-
1037-
then:
1038-
def assEx = thrown(AssertException)
1039-
assEx.message.contains("query can't be null")
1040-
1041-
1042-
}
10431018
}

0 commit comments

Comments
 (0)