Merge pull request #3801 from kilink/coerced-variables-empty-singleton

dondonz · web-flow · commit db35370003f5 · 2025-01-28T09:27:49.000+11:00
Return a singleton from CoercedVariables.emptyVariables and RawVariables.emptyVariables
diff --git a/src/main/java/graphql/execution/CoercedVariables.java b/src/main/java/graphql/execution/CoercedVariables.java
@@ -11,6 +11,7 @@
  */
 @PublicApi
 public class CoercedVariables {
+    private static final CoercedVariables EMPTY = CoercedVariables.of(ImmutableKit.emptyMap());
     private final ImmutableMapWithNullValues<String, Object> coercedVariables;
 
     public CoercedVariables(Map<String, Object> coercedVariables) {
@@ -30,7 +31,7 @@ public Object get(String key) {
     }
 
     public static CoercedVariables emptyVariables() {
-        return new CoercedVariables(ImmutableKit.emptyMap());
+        return EMPTY;
     }
 
     public static CoercedVariables of(Map<String, Object> coercedVariables) {
diff --git a/src/main/java/graphql/execution/RawVariables.java b/src/main/java/graphql/execution/RawVariables.java
@@ -11,6 +11,7 @@
  */
 @PublicApi
 public class RawVariables {
+    private static final RawVariables EMPTY = RawVariables.of(ImmutableKit.emptyMap());
     private final ImmutableMapWithNullValues<String, Object> rawVariables;
 
     public RawVariables(Map<String, Object> rawVariables) {
@@ -30,7 +31,7 @@ public Object get(String key) {
     }
 
     public static RawVariables emptyVariables() {
-        return RawVariables.of(ImmutableKit.emptyMap());
+        return EMPTY;
     }
 
     public static RawVariables of(Map<String, Object> rawVariables) {

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`	`*/`
`12`	`12`	`@PublicApi`
`13`	`13`	`public class CoercedVariables {`
	`14`	`+ private static final CoercedVariables EMPTY = CoercedVariables.of(ImmutableKit.emptyMap());`
`14`	`15`	`private final ImmutableMapWithNullValues<String, Object> coercedVariables;`
`15`	`16`
`16`	`17`	`public CoercedVariables(Map<String, Object> coercedVariables) {`
`@@ -30,7 +31,7 @@ public Object get(String key) {`
`30`	`31`	`}`
`31`	`32`
`32`	`33`	`public static CoercedVariables emptyVariables() {`
`33`		`- return new CoercedVariables(ImmutableKit.emptyMap());`
	`34`	`+ return EMPTY;`
`34`	`35`	`}`
`35`	`36`
`36`	`37`	`public static CoercedVariables of(Map<String, Object> coercedVariables) {`