Change GraphQL error message to be non-nullable

dondonz · dondonz · commit c78124cb3eac · 2025-12-07T15:00:17.000+11:00
diff --git a/src/main/java/graphql/GraphQLError.java b/src/main/java/graphql/GraphQLError.java
@@ -27,8 +27,12 @@ public interface GraphQLError extends Serializable {
 
     /**
      * @return a description of the error intended for the developer as a guide to understand and correct the error
+     *
+     * Non-nullable from the spec:
+     * Every error must contain an entry with the key "message" with a string description of the error intended for
+     * the developer as a guide to understand and correct the error.
      */
-    @Nullable String getMessage();
+    String getMessage();
 
     /**
      * @return the location(s) within the GraphQL document at which the error occurred. Each {@link SourceLocation}
diff --git a/src/main/java/graphql/validation/ValidationError.java b/src/main/java/graphql/validation/ValidationError.java
@@ -22,7 +22,7 @@
 public class ValidationError implements GraphQLError {
 
     private final List<SourceLocation> locations = new ArrayList<>();
-    private final @Nullable String description;
+    private final String description;
     private final @Nullable ValidationErrorClassification validationErrorType;
     private final List<String> queryPath = new ArrayList<>();
     private final ImmutableMap<String, Object> extensions;
@@ -46,11 +46,11 @@ private ValidationError(Builder builder) {
     }
 
     @Override
-    public @Nullable String getMessage() {
+    public String getMessage() {
         return description;
     }
 
-    public @Nullable String getDescription() {
+    public String getDescription() {
         return description;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`public class ValidationError implements GraphQLError {`
`23`	`23`
`24`	`24`	`private final List<SourceLocation> locations = new ArrayList<>();`
`25`		`- private final @Nullable String description;`
	`25`	`+ private final String description;`
`26`	`26`	`private final @Nullable ValidationErrorClassification validationErrorType;`
`27`	`27`	`private final List<String> queryPath = new ArrayList<>();`
`28`	`28`	`private final ImmutableMap<String, Object> extensions;`
`@@ -46,11 +46,11 @@ private ValidationError(Builder builder) {`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`@Override`
`49`		`- public @Nullable String getMessage() {`
	`49`	`+ public String getMessage() {`
`50`	`50`	`return description;`
`51`	`51`	`}`
`52`	`52`
`53`		`- public @Nullable String getDescription() {`
	`53`	`+ public String getDescription() {`
`54`	`54`	`return description;`
`55`	`55`	`}`
`56`	`56`