PR feedback on maming

bbakerman · bbakerman · commit c1c43f278ac5 · 2021-05-28T18:38:38.000+10:00
diff --git a/src/main/java/graphql/schema/GraphQLInputObjectField.java b/src/main/java/graphql/schema/GraphQLInputObjectField.java
@@ -101,7 +101,7 @@ public GraphQLInputType getType() {
      *
      * @return a value of type T which is the java value of the input field default
      */
-    public static <T> T getArgumentDefaultValue(GraphQLInputObjectField inputObjectField) {
+    public static <T> T getInputFieldDefaultValue(GraphQLInputObjectField inputObjectField) {
         return getInputValueImpl(inputObjectField.getType(), inputObjectField.getInputFieldDefaultValue());
     }
 
diff --git a/src/test/groovy/graphql/schema/GraphQLInputObjectFieldTest.groovy b/src/test/groovy/graphql/schema/GraphQLInputObjectFieldTest.groovy
@@ -65,7 +65,7 @@ class GraphQLInputObjectFieldTest extends Specification {
                 .defaultValueProgrammatic(1.23d)
                 .build()
         def inputValue = startingField.getInputFieldDefaultValue()
-        def resolvedValue = GraphQLInputObjectField.getArgumentDefaultValue(startingField)
+        def resolvedValue = GraphQLInputObjectField.getInputFieldDefaultValue(startingField)
 
         then:
         inputValue.isExternal()
@@ -80,7 +80,7 @@ class GraphQLInputObjectFieldTest extends Specification {
                 .defaultValueLiteral(FloatValue.newFloatValue().value(1.23d).build())
                 .build()
         inputValue = startingField.getInputFieldDefaultValue()
-        resolvedValue = GraphQLInputObjectField.getArgumentDefaultValue(startingField)
+        resolvedValue = GraphQLInputObjectField.getInputFieldDefaultValue(startingField)
 
         then:
         inputValue.isLiteral()
@@ -94,7 +94,7 @@ class GraphQLInputObjectFieldTest extends Specification {
                 .description("F1_description")
                 .build()
         inputValue = startingField.getInputFieldDefaultValue()
-        resolvedValue = GraphQLInputObjectField.getArgumentDefaultValue(startingField)
+        resolvedValue = GraphQLInputObjectField.getInputFieldDefaultValue(startingField)
 
         then:
         inputValue.isNotSet()

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public GraphQLInputType getType() {`
`101`	`101`	`*`
`102`	`102`	`* @return a value of type T which is the java value of the input field default`
`103`	`103`	`*/`
`104`		`- public static <T> T getArgumentDefaultValue(GraphQLInputObjectField inputObjectField) {`
	`104`	`+ public static <T> T getInputFieldDefaultValue(GraphQLInputObjectField inputObjectField) {`
`105`	`105`	`return getInputValueImpl(inputObjectField.getType(), inputObjectField.getInputFieldDefaultValue());`
`106`	`106`	`}`
`107`	`107`