avoid create redundant object; fix typo (#2090)

dugenkui03 · dugenkui · web-flow · commit a8fd5d36c2d9 · 2020-11-03T12:26:33.000+11:00
Co-authored-by: dugenkui &lt;dugenkui@dugenkuideMBP.lan&gt;
diff --git a/src/main/java/graphql/execution/AbortExecutionException.java b/src/main/java/graphql/execution/AbortExecutionException.java
@@ -67,13 +67,13 @@ public List<GraphQLError> getUnderlyingErrors() {
      * This is useful for turning this abort signal into an execution result which
      * is an error state with the underlying errors in it.
      *
-     * @return an excution result with the errors from this exception
+     * @return an execution result with the errors from this exception
      */
     public ExecutionResult toExecutionResult() {
-        ExecutionResult executionResult = new ExecutionResultImpl(this);
         if (!this.getUnderlyingErrors().isEmpty()) {
-            executionResult = new ExecutionResultImpl(this.getUnderlyingErrors());
+            return new ExecutionResultImpl(this.getUnderlyingErrors());
         }
-        return executionResult;
+
+        return new ExecutionResultImpl(this);
     }
 }
diff --git a/src/test/groovy/graphql/execution/AbortExecutionExceptionTest.groovy b/src/test/groovy/graphql/execution/AbortExecutionExceptionTest.groovy
@@ -26,7 +26,7 @@ class AbortExecutionExceptionTest extends Specification {
         }
     }
 
-    def "to excution result handling"() {
+    def "to execution result handling"() {
         AbortExecutionException e
         when:
         e = new AbortExecutionException("No underlying errors")

Original file line number	Diff line number	Diff line change
`@@ -67,13 +67,13 @@ public List<GraphQLError> getUnderlyingErrors() {`
`67`	`67`	`* This is useful for turning this abort signal into an execution result which`
`68`	`68`	`* is an error state with the underlying errors in it.`
`69`	`69`	`*`
`70`		`- * @return an excution result with the errors from this exception`
	`70`	`+ * @return an execution result with the errors from this exception`
`71`	`71`	`*/`
`72`	`72`	`public ExecutionResult toExecutionResult() {`
`73`		`- ExecutionResult executionResult = new ExecutionResultImpl(this);`
`74`	`73`	`if (!this.getUnderlyingErrors().isEmpty()) {`
`75`		`- executionResult = new ExecutionResultImpl(this.getUnderlyingErrors());`
	`74`	`+ return new ExecutionResultImpl(this.getUnderlyingErrors());`
`76`	`75`	`}`
`77`		`- return executionResult;`
	`76`	`+`
	`77`	`+ return new ExecutionResultImpl(this);`
`78`	`78`	`}`
`79`	`79`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class AbortExecutionExceptionTest extends Specification {`
`26`	`26`	`}`
`27`	`27`	`}`
`28`	`28`
`29`		`- def "to excution result handling"() {`
	`29`	`+ def "to execution result handling"() {`
`30`	`30`	`AbortExecutionException e`
`31`	`31`	`when:`
`32`	`32`	`e = new AbortExecutionException("No underlying errors")`