tests

andimarek · andimarek · commit a753b26580b8 · 2025-04-03T21:24:32.000+10:00
diff --git a/src/test/groovy/graphql/EngineRunningTest.groovy b/src/test/groovy/graphql/EngineRunningTest.groovy
@@ -56,6 +56,55 @@ class EngineRunningTest extends Specification {
         states == [RUNNING, NOT_RUNNING]
     }
 
+    def "multiple async DF"() {
+        given:
+        def sdl = '''
+
+        type Query {
+          hello: String
+            hello2: String
+        }
+        '''
+        CompletableFuture cf1 = new CompletableFuture();
+        def df1 = { env ->
+            return cf1;
+        } as DataFetcher
+        CompletableFuture cf2 = new CompletableFuture();
+        def df2 = { env ->
+            return cf2;
+        } as DataFetcher
+
+        def fetchers = ["Query": ["hello": df1, "hello2": df2]]
+        def schema = TestUtil.schema(sdl, fetchers)
+        def graphQL = GraphQL.newGraphQL(schema).build()
+
+        def query = "{ hello hello2 }"
+        def ei = newExecutionInput(query).build()
+
+        List<RunningState> states = trackStates(ei)
+
+        when:
+        def er = graphQL.executeAsync(ei)
+        then:
+        states == [RUNNING, NOT_RUNNING]
+
+        when:
+        states.clear();
+        cf1.complete("world")
+
+        then:
+        states == [RUNNING, NOT_RUNNING]
+
+        when:
+        states.clear()
+        cf2.complete("world2")
+
+        then:
+        states == [RUNNING, NOT_RUNNING]
+        er.get().data == [hello: "world", hello2: "world2"]
+    }
+
+
     def "engine running state is observed with one async datafetcher"() {
         given:
         def sdl = '''
@@ -172,6 +221,64 @@ class EngineRunningTest extends Specification {
         states == [RUNNING, NOT_RUNNING]
     }
 
+    def "async datafetcher failing with async exception handler"() {
+        given:
+        def sdl = '''
+
+        type Query {
+          hello: String
+        }
+        '''
+        def cf = new CompletableFuture();
+        def df = { env ->
+            return cf.thenApply { it -> throw new RuntimeException("boom") }
+        } as DataFetcher
+
+        ReentrantLock reentrantLock = new ReentrantLock()
+        reentrantLock.lock();
+
+        def exceptionHandler = { param ->
+            def async = CompletableFuture.supplyAsync {
+                reentrantLock.lock();
+                return DataFetcherExceptionHandlerResult.newResult(GraphqlErrorBuilder
+                        .newError(param.dataFetchingEnvironment).message("recovered").build()).build()
+            }
+            return async
+        } as DataFetcherExceptionHandler
+
+        def fetchers = ["Query": ["hello": df]]
+        def schema = TestUtil.schema(sdl, fetchers)
+        def graphQL = GraphQL.newGraphQL(schema).defaultDataFetcherExceptionHandler(exceptionHandler).build()
+
+        def query = "{ hello }"
+        def ei = newExecutionInput(query).build()
+
+        List<RunningState> states = trackStates(ei)
+
+        when:
+        def er = graphQL.executeAsync(ei)
+
+        then:
+        states == [RUNNING, NOT_RUNNING]
+
+        when:
+        states.clear()
+        cf.complete("foo")
+
+        then:
+        states == [RUNNING, NOT_RUNNING]
+
+        when:
+        states.clear()
+        reentrantLock.unlock()
+        def result = er.get()
+
+        then:
+        result.errors.collect { it.message } == ["recovered"]
+        // we expect simply going from running to finshed
+        states == [RUNNING, NOT_RUNNING]
+    }
+
 
     def "engine running state is observed with two async datafetcher"() {
         given:
