Avoids ArrayIndexOutOfBoundsException for description of only newline (#2053) (#2069)

omavi · web-flow · commit 7a8e9038df64 · 2020-10-06T18:47:34.000+11:00
* Adds test for field description of only a newline character (#2053) * Avoids ArrayIndexOutOfBoundsException for description of only newline (#2053)
diff --git a/src/main/java/graphql/schema/idl/SchemaPrinter.java b/src/main/java/graphql/schema/idl/SchemaPrinter.java
@@ -945,7 +945,7 @@ private void printComments(PrintWriter out, Object graphQLType, String prefix) {
             List<String> lines = Arrays.asList(descriptionText.split("\n"));
             if (options.isDescriptionsAsHashComments()) {
                 printMultiLineHashDescription(out, prefix, lines);
-            } else {
+            } else if (!lines.isEmpty()) {
                 if (lines.size() > 1) {
                     printMultiLineDescription(out, prefix, lines);
                 } else {
diff --git a/src/test/groovy/graphql/schema/idl/SchemaPrinterTest.groovy b/src/test/groovy/graphql/schema/idl/SchemaPrinterTest.groovy
@@ -663,6 +663,28 @@ type Query {
 '''
     }
 
+    def "arrayIndexOutOfBoundsException should not occur if a field description of only a newline is passed"() {
+        given:
+        GraphQLFieldDefinition fieldDefinition = newFieldDefinition()
+                .name("field")
+                .description("\n")
+                .type(GraphQLString)
+                .build()
+
+        def queryType = new MyTestGraphQLObjectType("Query", "test", Arrays.asList(fieldDefinition))
+        def schema = GraphQLSchema.newSchema().query(queryType).build()
+
+        when:
+        def result = new SchemaPrinter(noDirectivesOption).print(schema)
+
+        then:
+        result == '''"test"
+type Query {
+  field: String
+}
+'''
+    }
+
     def "schema will be sorted"() {
         def schema = TestUtil.schema("""
             type Query {
