Revert stricter parseValue coercion for Boolean

dondonz · dondonz · commit 753c2ecbb3d8 · 2023-04-14T15:21:39.000+10:00
diff --git a/src/main/java/graphql/scalar/GraphqlBooleanCoercing.java b/src/main/java/graphql/scalar/GraphqlBooleanCoercing.java
@@ -68,12 +68,13 @@ private Boolean serializeImpl(@NotNull Object input, @NotNull Locale locale) {
 
     @NotNull
     private Boolean parseValueImpl(@NotNull Object input, @NotNull Locale locale) {
-        if (!(input instanceof Boolean)) {
+        Boolean result = convertImpl(input);
+        if (result == null) {
             throw new CoercingParseValueException(
-                    i18nMsg(locale, "Boolean.unexpectedRawValueType", typeName(input))
+                    i18nMsg(locale, "Boolean.notBoolean", typeName(input))
             );
         }
-        return (Boolean) input;
+        return result;
     }
 
     private static boolean parseLiteralImpl(@NotNull Object input, @NotNull Locale locale) {
diff --git a/src/main/resources/i18n/Scalars.properties b/src/main/resources/i18n/Scalars.properties
@@ -28,4 +28,3 @@ Float.unexpectedRawValueType=Expected a Number input, but it was a ''{0}''
 #
 Boolean.notBoolean=Expected a value that can be converted to type ''Boolean'' but it was a ''{0}''
 Boolean.unexpectedAstType=Expected an AST type of ''BooleanValue'' but it was a ''{0}''
-Boolean.unexpectedRawValueType=Expected a Boolean input, but it was a ''{0}''
diff --git a/src/main/resources/i18n/Scalars_de.properties b/src/main/resources/i18n/Scalars_de.properties
@@ -28,4 +28,3 @@ Float.unexpectedRawValueType=Erwartet wurde eine Number-Eingabe, aber es war ein
 #
 Boolean.notBoolean=Erwartet wurde ein Wert, der in den Typ ''Boolean'' konvertiert werden kann, aber es war ein ''{0}''
 Boolean.unexpectedAstType=Erwartet wurde ein AST type ''BooleanValue'', aber es war ein ''{0}''
-Boolean.unexpectedRawValueType=Erwartet wurde eine Boolean-Eingabe, aber es war ein ''{0}''

Original file line number	Diff line number	Diff line change
`@@ -28,4 +28,3 @@ Float.unexpectedRawValueType=Expected a Number input, but it was a ''{0}''`
`28`	`28`	`#`
`29`	`29`	`Boolean.notBoolean=Expected a value that can be converted to type ''Boolean'' but it was a ''{0}''`
`30`	`30`	`Boolean.unexpectedAstType=Expected an AST type of ''BooleanValue'' but it was a ''{0}''`
`31`		`-Boolean.unexpectedRawValueType=Expected a Boolean input, but it was a ''{0}''`