Fix #244: Support for integer-valued ID fields

dminkovsky · dminkovsky · commit 73639da2c9c6 · 2016-11-28T10:25:10.000-05:00
diff --git a/src/main/java/graphql/Scalars.java b/src/main/java/graphql/Scalars.java
@@ -171,6 +171,9 @@ public Object serialize(Object input) {
             if (input instanceof String) {
                 return input;
             }
+            if (input instanceof Integer) {
+                return String.valueOf(input);
+            }
 
             return null;
         }
@@ -182,8 +185,13 @@ public Object parseValue(Object input) {
 
         @Override
         public Object parseLiteral(Object input) {
-            if (!(input instanceof StringValue)) return null;
-            return ((StringValue) input).getValue();
+            if (input instanceof StringValue) {
+                return ((StringValue) input).getValue();
+            }
+            if (input instanceof IntValue) {
+                return ((IntValue) input).getValue().toString();
+            }
+            return null;
         }
     });
 
diff --git a/src/test/groovy/graphql/ScalarsTest.groovy b/src/test/groovy/graphql/ScalarsTest.groovy
@@ -43,6 +43,7 @@ class ScalarsTest extends Specification {
         where:
         literal                               | result
         new StringValue("5457486ABSBHS4w646") | "5457486ABSBHS4w646"
+        new IntValue(BigInteger.ONE)          | "1"
     }
 
     @Unroll
@@ -54,6 +55,7 @@ class ScalarsTest extends Specification {
         where:
         value                | result
         "5457486ABSBHS4w646" | "5457486ABSBHS4w646"
+        1                    | "1"
         null                 | null
     }
 

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ class ScalarsTest extends Specification {`
`43`	`43`	`where:`
`44`	`44`	`literal \| result`
`45`	`45`	`new StringValue("5457486ABSBHS4w646") \| "5457486ABSBHS4w646"`
	`46`	`+ new IntValue(BigInteger.ONE) \| "1"`
`46`	`47`	`}`
`47`	`48`
`48`	`49`	`@Unroll`
`@@ -54,6 +55,7 @@ class ScalarsTest extends Specification {`
`54`	`55`	`where:`
`55`	`56`	`value \| result`
`56`	`57`	`"5457486ABSBHS4w646" \| "5457486ABSBHS4w646"`
	`58`	`+ 1 \| "1"`
`57`	`59`	`null \| null`
`58`	`60`	`}`
`59`	`61`