Iterate over implementations instead of allocating collections for isPossibleType

Marc-Andre Giroux · Marc-Andre Giroux · commit 4c27accdf712 · 2025-07-02T10:17:16.000-04:00
diff --git a/src/main/java/graphql/schema/idl/TypeDefinitionRegistry.java b/src/main/java/graphql/schema/idl/TypeDefinitionRegistry.java
@@ -623,9 +623,17 @@ public boolean isPossibleType(Type abstractType, Type possibleType) {
             return false;
         } else {
             InterfaceTypeDefinition iFace = (InterfaceTypeDefinition) abstractTypeDef;
-            List<ImplementingTypeDefinition> implementingTypeDefinitions = getAllImplementationsOf(iFace);
-            return implementingTypeDefinitions.stream()
-                    .anyMatch(od -> od.getName().equals(targetObjectTypeDef.getName()));
+
+            return types.values().stream()
+                    .filter(ImplementingTypeDefinition.class::isInstance)
+                    .filter(t -> t.getName().equals(targetObjectTypeDef.getName()))
+                    .map(td -> (ImplementingTypeDefinition<?>) td)
+                    .anyMatch(itd -> itd.getImplements()
+                            .stream()
+                            .map(TypeInfo::getTypeName)
+                            .map(tn -> types.get(tn.getName()))
+                            .anyMatch(td -> td.getName().equals(iFace.getName()))
+                    );
         }
     }
 
diff --git a/src/main/java/graphql/schema/idl/TypeInfo.java b/src/main/java/graphql/schema/idl/TypeInfo.java
@@ -26,6 +26,18 @@ public static TypeInfo typeInfo(Type type) {
         return new TypeInfo(type);
     }
 
+    public static TypeName getTypeName(Type type) {
+        while (!(type instanceof TypeName)) {
+            if (type instanceof NonNullType) {
+                type = ((NonNullType) type).getType();
+            }
+            if (type instanceof ListType) {
+                type = ((ListType) type).getType();
+            }
+        }
+        return (TypeName) type;
+    }
+
     private final Type rawType;
     private final TypeName typeName;
     private final Deque<Class<?>> decoration = new ArrayDeque<>();
