Merge pull request #3987 from jbellenger/jbellenger-error-location-ordering

dondonz · web-flow · commit 4b1f2316e805 · 2025-05-26T09:57:53.000+10:00
deterministic SourceLocation serialization
diff --git a/src/main/java/graphql/GraphqlErrorHelper.java b/src/main/java/graphql/GraphqlErrorHelper.java
@@ -73,7 +73,10 @@ public static Object location(SourceLocation location) {
         if (line < 1 || column < 1) {
             return null;
         }
-        return Map.of("line", line, "column", column);
+        LinkedHashMap<String, Object> map = new LinkedHashMap<>(2);
+        map.put("line", line);
+        map.put("column", column);
+        return map;
     }
 
     static List<GraphQLError> fromSpecification(List<Map<String, Object>> specificationMaps) {
diff --git a/src/test/groovy/graphql/GraphqlErrorHelperTest.groovy b/src/test/groovy/graphql/GraphqlErrorHelperTest.groovy
@@ -3,6 +3,7 @@ package graphql
 import graphql.language.SourceLocation
 import graphql.validation.ValidationError
 import graphql.validation.ValidationErrorType
+import spock.lang.RepeatUntilFailure
 import spock.lang.Specification
 
 class GraphqlErrorHelperTest extends Specification {
@@ -154,4 +155,15 @@ class GraphqlErrorHelperTest extends Specification {
             assert gErr.getExtensions() == null
         }
     }
+
+    @RepeatUntilFailure(maxAttempts = 1_000)
+    def "can deterministically serialize SourceLocation"() {
+        when:
+        def specMap = GraphqlErrorHelper.toSpecification(new TestError())
+
+        then:
+        def location = specMap["locations"][0] as Map<String, Object>
+        def keys = location.keySet().toList()
+        keys == ["line", "column"]
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,10 @@ public static Object location(SourceLocation location) {`
`73`	`73`	`if (line < 1 \|\| column < 1) {`
`74`	`74`	`return null;`
`75`	`75`	`}`
`76`		`- return Map.of("line", line, "column", column);`
	`76`	`+ LinkedHashMap<String, Object> map = new LinkedHashMap<>(2);`
	`77`	`+ map.put("line", line);`
	`78`	`+ map.put("column", column);`
	`79`	`+ return map;`
`77`	`80`	`}`
`78`	`81`
`79`	`82`	`static List<GraphQLError> fromSpecification(List<Map<String, Object>> specificationMaps) {`