id scalar will now use String.valueOf on serialise

bbakerman · bbakerman · commit 3c2ffc8b08c6 · 2020-01-03T13:27:38.000+11:00
diff --git a/src/main/java/graphql/Scalars.java b/src/main/java/graphql/Scalars.java
@@ -287,7 +287,7 @@ private String convertImpl(Object input) {
 
         @Override
         public String serialize(Object input) {
-            String result = convertImpl(input);
+            String result = String.valueOf(input);
             if (result == null) {
                 throw new CoercingSerializeException(
                         "Expected type 'ID' but was '" + typeName(input) + "'."
diff --git a/src/test/groovy/graphql/ScalarsIDTest.groovy b/src/test/groovy/graphql/ScalarsIDTest.groovy
@@ -51,11 +51,11 @@ class ScalarsIDTest extends Specification {
     }
 
     @Unroll
-    def "serialize throws exception for invalid input #value"() {
+    def "serialize allows any object via String.valueOf #value"() {
         when:
         Scalars.GraphQLID.getCoercing().serialize(value)
         then:
-        thrown(CoercingSerializeException)
+        noExceptionThrown()
 
         where:
         value        | _
