WIP: Notes after pairing with Andi

felipe-gdr-atlassian · felipe-gdr-atlassian · commit 37980a0a6f62 · 2024-06-24T12:41:54.000+10:00
diff --git a/src/main/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategyWithDefer.java b/src/main/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategyWithDefer.java
@@ -18,18 +18,31 @@
 
 @Internal
 public class PerLevelDataLoaderDispatchStrategyWithDefer implements DataLoaderDispatchStrategy {
+    // ITERATIONS:
+    // 1 - all defer fields should be ignored.
+    // 2 - new call stacks for every defer block.
 
     private final CallStack callStack;
     private final ExecutionContext executionContext;
 
+    // data fetchers state: 1) not called 2) called but not returned 3) called and resolve
+
+    // TODO: add test for only a scalar being deferred
 
     private static class CallStack {
 
         private final LockKit.ReentrantLock lock = new LockKit.ReentrantLock();
+
+        // expected data fetchers method invocations
         private final LevelMap expectedFetchCountPerLevel = new LevelMap();
+        // actual data fetchers that were invoked and returned
         private final LevelMap fetchCountPerLevel = new LevelMap();
+
+        // object stuff
         private final LevelMap expectedStrategyCallsPerLevel = new LevelMap();
         private final LevelMap happenedStrategyCallsPerLevel = new LevelMap();
+
+        // data fetchers methods have returned (returned an actual value, which we can inspect - it is list, non-null, object, etc....)
         private final LevelMap happenedOnFieldValueCallsPerLevel = new LevelMap();
 
         private final LevelMap expectedDeferredStrategyCallsPerLevel = new LevelMap();
diff --git a/src/test/groovy/graphql/execution/instrumentation/dataloader/DeferWithDataLoaderTest.groovy b/src/test/groovy/graphql/execution/instrumentation/dataloader/DeferWithDataLoaderTest.groovy
@@ -217,9 +217,11 @@ class DeferWithDataLoaderTest extends Specification {
                         name
                     }
                 } 
-                ... @defer(if: true) {
+                ... @defer {
                     expensiveShops {
-                        name 
+                        departments {
+                            name 
+                        }
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -217,9 +217,11 @@ class DeferWithDataLoaderTest extends Specification {`
`217`	`217`	`name`
`218`	`218`	`}`
`219`	`219`	`}`
`220`		`- ... @defer(if: true) {`
	`220`	`+ ... @defer {`
`221`	`221`	`expensiveShops {`
`222`		`- name`
	`222`	`+ departments {`
	`223`	`+ name`
	`224`	`+ }`
`223`	`225`	`}`
`224`	`226`	`}`
`225`	`227`	`}`