FpKit now longer uses streams for performance reasons - tweak

bbakerman · bbakerman · commit 36fc91c482a2 · 2025-04-27T10:55:54.000+10:00
diff --git a/src/main/java/graphql/util/FpKit.java b/src/main/java/graphql/util/FpKit.java
@@ -55,7 +55,7 @@ public static <T, NewKey> Map<NewKey, T> toMap(Collection<T> collection, Functio
 
     // normal groupingBy but with LinkedHashMap
     public static <T, NewKey> Map<NewKey, ImmutableList<T>> groupingBy(Collection<T> list, Function<T, NewKey> function) {
-        return filterAndGroupingBy(list, t -> true, function);
+        return filterAndGroupingBy(list, ALWAYS_TRUE, function);
     }
 
     @SuppressWarnings("unchecked")
@@ -93,10 +93,13 @@ public static <T, NewKey> Map<NewKey, T> toMapByUniqueKey(Collection<T> list, Fu
     }
 
 
+    private static final Predicate<Object> ALWAYS_TRUE = o -> true;
+
     private static final BinaryOperator<Object> THROWING_MERGER_SINGLETON = (u, v) -> {
         throw new IllegalStateException(String.format("Duplicate key %s", u));
     };
 
+
     private static <T> BinaryOperator<T> throwingMerger() {
         //noinspection unchecked
         return (BinaryOperator<T>) THROWING_MERGER_SINGLETON;
