change: This is maybe a breaking change: GraphQLFloat now returns double instead of float.

andimarek · andimarek · commit 3062e2b48503 · 2016-01-23T10:15:11.000+01:00
The naming is unfortunately based on float = double precision according to the spec.  This clashes with the Java world where float != double.
diff --git a/src/main/java/graphql/Scalars.java b/src/main/java/graphql/Scalars.java
@@ -68,13 +68,15 @@ public Object parseLiteral(Object input) {
 
     public static GraphQLScalarType GraphQLFloat = new GraphQLScalarType("Float", "Built-in Float", new Coercing() {
         @Override
-        public Float serialize(Object input) {
+        public Double serialize(Object input) {
             if (input instanceof String) {
-                return Float.parseFloat((String) input);
+                return Double.parseDouble((String) input);
+            } else if (input instanceof Double) {
+                return (Double) input;
             } else if (input instanceof Float) {
-                return (Float) input;
+                return (double) (Float) input;
             } else if (input instanceof Integer) {
-                return (float) (Integer) input;
+                return (double) (Integer) input;
             } else {
                 return null;
             }
diff --git a/src/test/groovy/graphql/ScalarsTest.groovy b/src/test/groovy/graphql/ScalarsTest.groovy
@@ -5,7 +5,7 @@ import graphql.language.FloatValue
 import graphql.language.IntValue
 import graphql.language.StringValue
 import spock.lang.Specification
-
+import spock.lang.Unroll
 
 class ScalarsTest extends Specification {
 
@@ -107,18 +107,20 @@ class ScalarsTest extends Specification {
         new FloatValue(42.3) | 42.3f
     }
 
-    def "Float serialize/parseValue object"() {
+    @Unroll
+    def "Float serialize/parseValue #value into #result"() {
         expect:
         Scalars.GraphQLFloat.getCoercing().serialize(value) == result
         Scalars.GraphQLFloat.getCoercing().parseValue(value) == result
 
         where:
-        value           | result
-        "42.3"          | 42.3f
-        "42.0"          | 42.0f
-        new Float(42.3) | 42.3f
-        10              | 10.0f
-        null            | null
+        value      | result
+        "11.3"     | 11.3d
+        "24.0"     | 24.0d
+        42.3f      | 42.3f
+        10         | 10.0d
+        90.000004d | 90.000004d
+        null       | null
     }
 
     def "Boolean parse literal"() {
diff --git a/src/test/groovy/graphql/execution/ValuesResolverTest.groovy b/src/test/groovy/graphql/execution/ValuesResolverTest.groovy
@@ -32,7 +32,7 @@ class ValuesResolverTest extends Specification {
         GraphQLInt     | new TypeName("Int")     | 100          || 100
         GraphQLString  | new TypeName("String")  | 'someString' || 'someString'
         GraphQLBoolean | new TypeName("Boolean") | 'true'       || true
-        GraphQLFloat   | new TypeName("Float")   | '42.43'      || 42.43f
+        GraphQLFloat | new TypeName("Float") | '42.43' || 42.43d
 
     }
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ class ValuesResolverTest extends Specification {`
`32`	`32`	`GraphQLInt \| new TypeName("Int") \| 100 \|\| 100`
`33`	`33`	`GraphQLString \| new TypeName("String") \| 'someString' \|\| 'someString'`
`34`	`34`	`GraphQLBoolean \| new TypeName("Boolean") \| 'true' \|\| true`
`35`		`- GraphQLFloat \| new TypeName("Float") \| '42.43' \|\| 42.43f`
	`35`	`+ GraphQLFloat \| new TypeName("Float") \| '42.43' \|\| 42.43d`
`36`	`36`
`37`	`37`	`}`
`38`	`38`