remove Thread.onSpinWait again as not clear this is needed or has maybe negative effects

andimarek · andimarek · commit 2eecad7ba630 · 2025-09-25T06:59:14.000+10:00
diff --git a/src/main/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java b/src/main/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java
@@ -97,7 +97,6 @@ public StateForLevel(@Nullable DataLoaderInvocation dataLoaderInvocation,
                 if (currentStateRef.compareAndSet(currentState, newState)) {
                     return currentState;
                 }
-                Thread.onSpinWait();
             }
         }
 
@@ -125,7 +124,6 @@ public boolean newDataLoaderInvocation(DataLoaderInvocation dataLoaderInvocation
                 if (currentStateRef.compareAndSet(currentState, newState)) {
                     return newDelayedInvocation;
                 }
-                Thread.onSpinWait();
             }
         }
 
@@ -261,7 +259,6 @@ public void executeObject(ExecutionContext executionContext, ExecutionStrategyPa
             if (callStack.tryUpdateLevel(curLevel, currentState, currentState.increaseHappenedExecuteObjectCalls())) {
                 return;
             }
-            Thread.onSpinWait();
         }
     }
 
@@ -286,7 +283,6 @@ private void onCompletionFinished(int level, CallStack callStack) {
             if (callStack.tryUpdateLevel(level, currentState, currentState.increaseHappenedCompletionFinishedCount())) {
                 break;
             }
-            Thread.onSpinWait();
         }
 
         // due to synchronous DataFetcher the completion calls on higher levels
@@ -348,7 +344,6 @@ public void subscriptionEventCompletionDone(AlternativeCallContext alternativeCa
             if (callStack.tryUpdateLevel(0, currentState, currentState.increaseHappenedExecuteObjectCalls())) {
                 break;
             }
-            Thread.onSpinWait();
         }
         onCompletionFinished(0, callStack);
     }

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,6 @@ public StateForLevel(@Nullable DataLoaderInvocation dataLoaderInvocation,`
`97`	`97`	`if (currentStateRef.compareAndSet(currentState, newState)) {`
`98`	`98`	`return currentState;`
`99`	`99`	`}`
`100`		`- Thread.onSpinWait();`
`101`	`100`	`}`
`102`	`101`	`}`
`103`	`102`
`@@ -125,7 +124,6 @@ public boolean newDataLoaderInvocation(DataLoaderInvocation dataLoaderInvocation`
`125`	`124`	`if (currentStateRef.compareAndSet(currentState, newState)) {`
`126`	`125`	`return newDelayedInvocation;`
`127`	`126`	`}`
`128`		`- Thread.onSpinWait();`
`129`	`127`	`}`
`130`	`128`	`}`
`131`	`129`
`@@ -261,7 +259,6 @@ public void executeObject(ExecutionContext executionContext, ExecutionStrategyPa`
`261`	`259`	`if (callStack.tryUpdateLevel(curLevel, currentState, currentState.increaseHappenedExecuteObjectCalls())) {`
`262`	`260`	`return;`
`263`	`261`	`}`
`264`		`- Thread.onSpinWait();`
`265`	`262`	`}`
`266`	`263`	`}`
`267`	`264`
`@@ -286,7 +283,6 @@ private void onCompletionFinished(int level, CallStack callStack) {`
`286`	`283`	`if (callStack.tryUpdateLevel(level, currentState, currentState.increaseHappenedCompletionFinishedCount())) {`
`287`	`284`	`break;`
`288`	`285`	`}`
`289`		`- Thread.onSpinWait();`
`290`	`286`	`}`
`291`	`287`
`292`	`288`	`// due to synchronous DataFetcher the completion calls on higher levels`
`@@ -348,7 +344,6 @@ public void subscriptionEventCompletionDone(AlternativeCallContext alternativeCa`
`348`	`344`	`if (callStack.tryUpdateLevel(0, currentState, currentState.increaseHappenedExecuteObjectCalls())) {`
`349`	`345`	`break;`
`350`	`346`	`}`
`351`		`- Thread.onSpinWait();`
`352`	`347`	`}`
`353`	`348`	`onCompletionFinished(0, callStack);`
`354`	`349`	`}`