Merge pull request #3886 from RafeArnold/handle-null-error-locations

bbakerman · web-flow · commit 23012ad7be8b · 2025-04-04T14:11:21.000+11:00
filter out null error location in toSpecification
diff --git a/src/main/java/graphql/GraphqlErrorHelper.java b/src/main/java/graphql/GraphqlErrorHelper.java
@@ -65,6 +65,9 @@ public static Object locations(List<SourceLocation> locations) {
      * @return a value for source location of the error
      */
     public static Object location(SourceLocation location) {
+        if (location == null) {
+            return null;
+        }
         int line = location.getLine();
         int column = location.getColumn();
         if (line < 1 || column < 1) {
diff --git a/src/test/groovy/graphql/GraphQLErrorTest.groovy b/src/test/groovy/graphql/GraphQLErrorTest.groovy
@@ -94,6 +94,26 @@ class GraphQLErrorTest extends Specification {
         error.toSpecification() == expectedMap
     }
 
+    def "toSpecification filters out null error locations"() {
+        given:
+        def error = ValidationError.newValidationError()
+                .validationErrorType(ValidationErrorType.UnknownType)
+                .sourceLocations([null, mkLocation(333, 1)])
+                .description("Test ValidationError")
+                .build()
+
+        def expectedMap = [
+                locations: [
+                        [line: 333, column: 1]
+                ],
+                message: "Test ValidationError",
+                extensions: [classification:"ValidationError"]
+        ]
+
+        expect:
+        error.toSpecification() == expectedMap
+    }
+
     class CustomException extends RuntimeException implements GraphQLError {
         private LinkedHashMap<String, String> map
 
