Skip to content

Commit 20dd35b

Browse files
authored
Merge pull request #3093 from graphql-java/fix-javax-annotations
Replace javax nullable annotations with JetBrains equivalent
2 parents 3422613 + 3f3b017 commit 20dd35b

4 files changed

Lines changed: 7 additions & 9 deletions

File tree

src/main/java/graphql/execution/instrumentation/ExecutionStrategyInstrumentationContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
import graphql.Internal;
55
import graphql.PublicSpi;
66
import graphql.execution.FieldValueInfo;
7+
import org.jetbrains.annotations.NotNull;
78

8-
import javax.annotation.Nonnull;
99
import java.util.List;
1010
import java.util.concurrent.CompletableFuture;
1111

@@ -27,7 +27,7 @@ default void onFieldValuesException() {
2727
*
2828
* @return a non null {@link InstrumentationContext} that maybe a no-op
2929
*/
30-
@Nonnull
30+
@NotNull
3131
@Internal
3232
static ExecutionStrategyInstrumentationContext nonNullCtx(ExecutionStrategyInstrumentationContext nullableContext) {
3333
return nullableContext == null ? NOOP : nullableContext;

src/main/java/graphql/execution/instrumentation/SimpleInstrumentationContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package graphql.execution.instrumentation;
22

33
import graphql.PublicApi;
4+
import org.jetbrains.annotations.NotNull;
45

5-
import javax.annotation.Nonnull;
66
import java.util.concurrent.CompletableFuture;
77
import java.util.function.BiConsumer;
88
import java.util.function.Consumer;
@@ -43,7 +43,7 @@ public static <T> InstrumentationContext<T> noOp() {
4343
*
4444
* @return a non null {@link InstrumentationContext} that maybe a no-op
4545
*/
46-
@Nonnull
46+
@NotNull
4747
public static <T> InstrumentationContext<T> nonNullCtx(InstrumentationContext<T> nullableContext) {
4848
return nullableContext == null ? noOp() : nullableContext;
4949
}

src/main/java/graphql/parser/GraphqlAntlrToLanguage.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package graphql.parser;
22

3-
43
import com.google.common.collect.ImmutableList;
54
import graphql.Assert;
65
import graphql.Internal;
@@ -68,8 +67,8 @@
6867
import org.antlr.v4.runtime.ParserRuleContext;
6968
import org.antlr.v4.runtime.Token;
7069
import org.antlr.v4.runtime.tree.TerminalNode;
70+
import org.jetbrains.annotations.Nullable;
7171

72-
import javax.annotation.Nullable;
7372
import java.math.BigDecimal;
7473
import java.math.BigInteger;
7574
import java.util.ArrayList;

src/main/java/graphql/schema/GraphQLEnumType.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package graphql.schema;
22

3-
43
import com.google.common.collect.ImmutableList;
54
import com.google.common.collect.ImmutableMap;
65
import graphql.DirectivesUtil;
@@ -14,8 +13,8 @@
1413
import graphql.util.FpKit;
1514
import graphql.util.TraversalControl;
1615
import graphql.util.TraverserContext;
16+
import org.jetbrains.annotations.NotNull;
1717

18-
import javax.annotation.Nonnull;
1918
import java.util.ArrayList;
2019
import java.util.LinkedHashMap;
2120
import java.util.List;
@@ -149,7 +148,7 @@ private ImmutableMap<String, GraphQLEnumValueDefinition> buildMap(List<GraphQLEn
149148
(fld1, fld2) -> assertShouldNeverHappen("Duplicated definition for field '%s' in type '%s'", fld1.getName(), this.name)));
150149
}
151150

152-
private Object getValueByName(@Nonnull Object value, GraphQLContext graphQLContext, Locale locale) {
151+
private Object getValueByName(@NotNull Object value, GraphQLContext graphQLContext, Locale locale) {
153152
GraphQLEnumValueDefinition enumValueDefinition = valueDefinitionMap.get(value.toString());
154153
if (enumValueDefinition != null) {
155154
return enumValueDefinition.getValue();

0 commit comments

Comments
 (0)