fix: parseLiteral for GraphQLFloat should also return double, not float

andimarek · andimarek · commit 113a9d018910 · 2016-02-19T12:49:28.000+01:00
diff --git a/src/main/java/graphql/Scalars.java b/src/main/java/graphql/Scalars.java
@@ -89,7 +89,7 @@ public Object parseValue(Object input) {
 
         @Override
         public Object parseLiteral(Object input) {
-            return ((FloatValue) input).getValue().floatValue();
+            return ((FloatValue) input).getValue().doubleValue();
         }
     });
 
diff --git a/src/test/groovy/graphql/ScalarsTest.groovy b/src/test/groovy/graphql/ScalarsTest.groovy
@@ -104,7 +104,7 @@ class ScalarsTest extends Specification {
 
         where:
         literal              | result
-        new FloatValue(42.3) | 42.3f
+        new FloatValue(42.3) | 42.3d
     }
 
     @Unroll

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public Object parseValue(Object input) {`
`89`	`89`
`90`	`90`	`@Override`
`91`	`91`	`public Object parseLiteral(Object input) {`
`92`		`- return ((FloatValue) input).getValue().floatValue();`
	`92`	`+ return ((FloatValue) input).getValue().doubleValue();`
`93`	`93`	`}`
`94`	`94`	`});`
`95`	`95`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ class ScalarsTest extends Specification {`
`104`	`104`
`105`	`105`	`where:`
`106`	`106`	`literal \| result`
`107`		`- new FloatValue(42.3) \| 42.3f`
	`107`	`+ new FloatValue(42.3) \| 42.3d`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`@Unroll`