Add test for good faith disabled with custom validation predicate

andimarek · claude · andimarek · commit 0e77994bc5df · 2026-03-23T11:30:22.000+10:00
Covers the lambda branch in GraphQL.validate() where good faith is
disabled and an existing custom rule predicate also excludes a rule,
exercising the &amp;&amp; short-circuit path.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/test/groovy/graphql/introspection/GoodFaithIntrospectionTest.groovy b/src/test/groovy/graphql/introspection/GoodFaithIntrospectionTest.groovy
@@ -2,10 +2,12 @@ package graphql.introspection
 
 import graphql.ExecutionInput
 import graphql.ExecutionResult
+import graphql.ParseAndValidate
 import graphql.TestUtil
 import graphql.execution.CoercedVariables
 import graphql.language.Document
 import graphql.normalized.ExecutableNormalizedOperationFactory
+import graphql.validation.OperationValidationRule
 import graphql.validation.QueryComplexityLimits
 import spock.lang.Specification
 
@@ -143,6 +145,24 @@ class GoodFaithIntrospectionTest extends Specification {
         er.errors.isEmpty()
     }
 
+    def "disabling good faith composes with custom validation rule predicates"() {
+        given:
+        // Custom predicate that disables a specific rule
+        def customPredicate = { OperationValidationRule rule -> rule != OperationValidationRule.KNOWN_ARGUMENT_NAMES } as java.util.function.Predicate
+
+        when:
+        def context = [
+                (GoodFaithIntrospection.GOOD_FAITH_INTROSPECTION_DISABLED)    : true,
+                (ParseAndValidate.INTERNAL_VALIDATION_PREDICATE_HINT)         : customPredicate
+        ]
+        ExecutionInput executionInput = ExecutionInput.newExecutionInput("{ normalField }")
+                .graphQLContext(context).build()
+        ExecutionResult er = graphql.execute(executionInput)
+
+        then:
+        er.errors.isEmpty()
+    }
+
     def "can be disabled per request"() {
         when:
         def context = [(GoodFaithIntrospection.GOOD_FAITH_INTROSPECTION_DISABLED): true]
