fix: don't treat empty operation name as special

RafeArnold · RafeArnold · commit 0c4d26d95b7d · 2026-01-21T17:30:23.000Z
previously, if an empty operation name was given and multiple
operations were provided in the query, then the first operation would be
 returned. not entirely sure why this would be the desired behaviour,
 when an exception would be thrown for any other value that doesn't
 match an existing operation in the query.
diff --git a/src/main/java/graphql/language/NodeUtil.java b/src/main/java/graphql/language/NodeUtil.java
@@ -78,7 +78,7 @@ public static GetOperationResult getOperation(Document document, String operatio
         }
         OperationDefinition operation;
 
-        if (operationName == null || operationName.isEmpty()) {
+        if (operationName == null) {
             operation = operationsByName.values().iterator().next();
         } else {
             operation = operationsByName.get(operationName);
diff --git a/src/test/groovy/graphql/language/NodeUtilTest.groovy b/src/test/groovy/graphql/language/NodeUtilTest.groovy
@@ -30,11 +30,14 @@ class NodeUtilTest extends Specification {
         ''')
 
         when:
-        NodeUtil.getOperation(doc, 'Unknown')
+        NodeUtil.getOperation(doc, operationName)
 
         then:
         def ex = thrown(UnknownOperationException)
-        ex.message == "Unknown operation named 'Unknown'."
+        ex.message == "Unknown operation named '$operationName'."
+
+        where:
+        operationName << ['Unknown', '']
     }
 
     def d1 = Directive.newDirective().name("d1").build()

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public static GetOperationResult getOperation(Document document, String operatio`
`78`	`78`	`}`
`79`	`79`	`OperationDefinition operation;`
`80`	`80`
`81`		`- if (operationName == null \|\| operationName.isEmpty()) {`
	`81`	`+ if (operationName == null) {`
`82`	`82`	`operation = operationsByName.values().iterator().next();`
`83`	`83`	`} else {`
`84`	`84`	`operation = operationsByName.get(operationName);`