Disable unnecessary linters, delint some code...

sqrrrl · sqrrrl · commit 67b332bf5c88 · 2021-12-03T17:02:53.000-07:00
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
@@ -1,16 +1,22 @@
+# Summary
+
+TODO...
+
 ## Expected Behavior
 
+TODO...
 
 ## Actual Behavior
 
+TODo...
 
 ## Steps to Reproduce the Problem
 
 1.
 1.
 1.
 
-## Specifications
+# Specifications
 
 - Python version (`python --version`)
 - OS (Mac/Linux/Windows)
diff --git a/.github/scripts/lint.sh b/.github/scripts/lint.sh
@@ -21,7 +21,7 @@ export LANG=C.UTF-8
 CL_FILE="${HOME}/changed_files.txt"
 
 if [ -f "${CL_FILE}" ] && ! grep -q .pylintrc "${CL_FILE}"; then
-  cat "${HOME}/changed_files.txt" | grep ".py$" | xargs pylint
+  grep ".py$" "${HOME}/changed_files.txt"| xargs pylint
 else
-  find . -iname "*.py" | xargs pylint
+  find . -iname "*.py" -print0 | xargs pylint
 fi
diff --git a/.github/scripts/test.sh b/.github/scripts/test.sh
@@ -18,17 +18,18 @@ export LANG=C.UTF-8
 export PIPENV_PYTHON="${PYENV_ROOT}/shims/python"
 export GOOGLE_APPLICATION_CREDENTIALS="${HOME}/secrets/default_credentials.json"
 
+dirs=()
+
 if [ -f "requirements.txt" ]; then
   pipenv install -r "requirements.txt"
 fi
 
-TEST_DIRS=`find . -name '*_test.py' -exec dirname '{}' \;| sort -u`
+IFS=$'\n' read -r -d '' -a dirs < <( find . -name '*_test.py' -exec dirname '{}' \; | sort -u )
 
 exit_code=0
 
-for DIR in ${TEST_DIRS[@]}; do
-  pushd "${DIR}"
-  echo $DIR
+for dir in "${dirs[@]}"; do
+  pushd "${dir}" || exit
   if [ -f "requirements.txt" ]; then
     # If requirements.txt present, create a new isolated environment
     touch Pipfile
@@ -39,7 +40,7 @@ for DIR in ${TEST_DIRS[@]}; do
   if [ $status -ne 0 ]; then 
     exit_code=$status
   fi
-  popd
+  popd || exit
 done
 
 if [ $exit_code -ne 0 ]; then
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -20,8 +20,8 @@ jobs:
       - name: Fetch and Diff PR with base from which it was cloned
         if: ${{ github.event.pull_request.base.sha }}
         run: |
-          git fetch origin main ${{ github.event.pull_request.base.sha }}
-          git diff  --diff-filter=ACM --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }} > $HOME/changed_files.txt
+          git fetch origin main "${{ github.event.pull_request.base.sha }}"
+          git diff  --diff-filter=ACM --name-only "${{ github.event.pull_request.base.sha }}" "${{ github.sha }}" > "${HOME}/changed_files.txt"
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v2
         with:
@@ -32,9 +32,9 @@ jobs:
           pip install pipenv
       - name: Write test credentials
         run: |
-          mkdir $HOME/secrets
-          echo "$DEFAULT_CREDENTIALS" > $HOME/secrets/default_credentials.json
-          echo "$CLIENT_ID_FILE" > $HOME/secrets/client_id.json
+          mkdir "${HOME}/secrets"
+          echo "${DEFAULT_CREDENTIALS}" > "${HOME}/secrets/default_credentials.json"
+          echo "${CLIENT_ID_FILE}" > "${HOME}/secrets/client_id.json"
         env:
           DEFAULT_CREDENTIALS: ${{secrets.SNIPPETS_DEFAULT_CREDENTIALS}}
           CLIENT_ID_FILE: ${{secrets.SNIPPETS_CLIENT_ID_FILE}}
diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml
@@ -23,5 +23,7 @@ jobs:
       - uses: github/super-linter/slim@v4.8.4
         env:
           ERROR_ON_MISSING_EXEC_BIT: true
+          VALIDATE_JSCPD: false
+          VALIDATE_PYTHON_BLACK: false
           VALIDATE_ALL_CODEBASE: ${{ github.event_name == 'push' }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
