From 8f54d4afad2f41934adcbb294be47130a784e219 Mon Sep 17 00:00:00 2001 From: Chris Arriola Date: Fri, 20 Dec 2019 14:05:42 -0800 Subject: [PATCH 1/2] style: Update pull request template. --- .../PULL_REQUEST_TEMPLATE/pull_request_template.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 2bbfe499..50db69ca 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,6 +1,7 @@ ---- -name: Pull request -about: Create a pull request -label: 'triage me' +Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: +- [ ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea +- [ ] Ensure the tests and linter pass +- [ ] Code coverage does not decrease (if any source code was changed) +- [ ] Appropriate docs were updated (if necessary) ---- +Fixes # 🦕 From 8b26242359a63756c03a1b69d1e825c37500918e Mon Sep 17 00:00:00 2001 From: Chris Arriola Date: Fri, 20 Dec 2019 15:53:33 -0800 Subject: [PATCH 2/2] Add back name, about and label. --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 50db69ca..4d7d59e9 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,3 +1,8 @@ +--- +name: Pull request +about: Create a pull request +label: 'triage me' +--- Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass