-
Notifications
You must be signed in to change notification settings - Fork 96
Python: noxfile support for extras #838
Copy link
Copy link
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
We have the following template variables for installing dependencies:
unit_test_external_dependencies-- install package from PyPIunit_test_local_dependencies-- install package (in editable mode) from local nearby git (not relevant for non-mono-repo?)unit_test_dependencies-- same asunit_test_local_dependencies?system_test_external_dependencies-- install package from PyPIsystem_test_local_dependencies-- install package (in editable mode) from local nearby git (not relevant for non-mono-repo?)In BigQuery, we actually use
system_test_local_dependenciesandunit_test_local_dependenciesto install "extras", but then we have logic to remove the redundantsession.install("-e", ".")(see: googleapis/python-bigquery-storage#93)I propose the following additional template parameters:
unit_test_extras_dependenciessystem_test_extras_dependenciesWhen these are populated, it'll change
session.install("-e", ".")tosession.install("-e", ".[dep1,dep2]").